Stone_Red/dvc
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/dvc.git synced 2026-11-08 07:18:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1047 from efiop/master

Browse Source 
s3: properly configure session and clients
This commit is contained in:
Ruslan Kuprieiev
2018-08-23 10:36:16 +03:00
committed by GitHub
parent f682e556ec 9d303b6b1b
commit 2ff7d9b571
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dvc/remote/s3.py
+9 -6
View File
@@ -57,6 +57,7 @@ class RemoteS3(RemoteBase):
else:
creds = {}
self.creds = creds
self.region = creds.get('region', self.region)
self.aws_access_key_id = creds.get('aws_access_key_id', None)
self.aws_secret_access_key = creds.get('aws_secret_access_key', None)
@@ -71,12 +72,14 @@ class RemoteS3(RemoteBase):
@property
def s3(self):
session = boto3.session.Session(profile_name=self.profile)
return session.client('s3',
aws_access_key_id=self.aws_access_key_id,
aws_secret_access_key=self.aws_secret_access_key,
region_name=self.region,
endpoint_url=self.endpoint_url)
if not self.creds:
session = boto3.session.Session(profile_name=self.profile)
else:
session = boto3.session.Session(
aws_access_key_id=self.aws_access_key_id,
aws_secret_access_key=self.aws_secret_access_key,
region_name=self.region)
return session.client('s3', endpoint_url=self.endpoint_url)
def get_etag(self, bucket, key):
try: