[PR #98] [MERGED] Fix/inconsistant prisma errors #98

New Issue

2026-09-04T00:22:07+02:00

Stone_Red commented

2026-09-04 00:22:07 +02:00

📋 Pull Request Information

Original PR: https://github.com/detleph/server/pull/98
Author: @Flexla54
Created: 12/26/2022
Status: ✅ Merged
Merged: 1/2/2023
Merged by: @Flexla54

Base: dev ← Head: fix/inconsistantPrismaErrors

📝 Commits (5)

2d794ce basic errorhandling inconsistancy fix
3d60e2b fixed inconsitencies with NotFoundError
581bb1b updated disci response message logically
c1dde00 corrected linking error to NotFoundError
6f40acb fixed deleteOrganisation response

📊 Changes

9 files changed (+97 additions, -155 deletions)

View changed files

📝 src/Controllers/admin.controller.ts (+5 -18)
📝 src/Controllers/common.ts (+6 -22)
📝 src/Controllers/discipline.controller.ts (+4 -0)
📝 src/Controllers/event.controller.ts (+15 -38)
📝 src/Controllers/group.controllers.ts (+43 -53)
📝 src/Controllers/organisation.controller.ts (+5 -15)
📝 src/Controllers/participant.controller.ts (+12 -5)
📝 src/Controllers/user_auth.controller.ts (+1 -1)
📝 src/Middleware/auth/defaultAdmin.ts (+6 -3)

📄 Description

Fix for issue #95

Basically replaced redundant and inconsistant implementations of the NotFoundError;
Updated logic that default admin is only shown when the server has been created for the first time;
Implemented more performant solution for checking wether the team is full or not.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/detleph/server/pull/98 **Author:** [@Flexla54](https://github.com/Flexla54) **Created:** 12/26/2022 **Status:** ✅ Merged **Merged:** 1/2/2023 **Merged by:** [@Flexla54](https://github.com/Flexla54) **Base:** `dev` ← **Head:** `fix/inconsistantPrismaErrors` --- ### 📝 Commits (5) - [`2d794ce`](https://github.com/detleph/server/commit/2d794cef30b9d7dc88b958be937711ab0cddb818) basic errorhandling inconsistancy fix - [`3d60e2b`](https://github.com/detleph/server/commit/3d60e2b652dce618be2dea246ede18301358a66a) fixed inconsitencies with NotFoundError - [`581bb1b`](https://github.com/detleph/server/commit/581bb1bb8a6c4146110a53776e87fbaa33285ea5) updated disci response message logically - [`c1dde00`](https://github.com/detleph/server/commit/c1dde00b0b5f2cb5e30a87d3de0734f55c282eb6) corrected linking error to NotFoundError - [`6f40acb`](https://github.com/detleph/server/commit/6f40acbf15a713ca812052b0d2d16f00864336b0) fixed deleteOrganisation response ### 📊 Changes **9 files changed** (+97 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `src/Controllers/admin.controller.ts` (+5 -18) 📝 `src/Controllers/common.ts` (+6 -22) 📝 `src/Controllers/discipline.controller.ts` (+4 -0) 📝 `src/Controllers/event.controller.ts` (+15 -38) 📝 `src/Controllers/group.controllers.ts` (+43 -53) 📝 `src/Controllers/organisation.controller.ts` (+5 -15) 📝 `src/Controllers/participant.controller.ts` (+12 -5) 📝 `src/Controllers/user_auth.controller.ts` (+1 -1) 📝 `src/Middleware/auth/defaultAdmin.ts` (+6 -3) </details> ### 📄 Description Fix for issue #95 - Basically replaced redundant and inconsistant implementations of the NotFoundError; - Updated logic that default admin is only shown when the server has been created for the first time; - Implemented more performant solution for checking wether the team is full or not. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

Stone_Red added the pull-request label 2026-09-04 00:22:07 +02:00

Stone_Red closed this issue

2026-09-04 00:22:07 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: detleph/server#98