mirror of
https://github.com/Stone-Red-Code/dvc.git
synced 2026-11-02 07:18:25 +01:00
Paweł Redzyński
21af7438db
* params/metrics/plots/exp show: introduce onerror * fixup * plots/metrics/params: removing errors * removing more errors * removing errors * some more removing * new plots ux * new ux for metrics * new ux for params * fixing tests * fixups * minor test fixes * minor test fixes * commands: plots/params: fix ui imports * working on error handlng decorator, stopped at show checkpoints * error_handler, further dvelopment * plots just before moving loading to collect * appending errors to results: initial passing * fixup * onerror: remove onerror fixture * fixups * plots/metrics/params/experiments: temporarily remove error warnings * plots: extract parsing out of class method * metrics/experiments: provide exception serializer for show-json * params/plots/metrics: signal errors * rebase fixups * fix TODOs * fixup * skshetry's review refactor
176 lines
4.4 KiB
Python
176 lines
4.4 KiB
Python
import os
|
|
import posixpath
|
|
|
|
import pytest
|
|
|
|
from dvc.cli import parse_args
|
|
from dvc.command.plots import CmdPlotsDiff, CmdPlotsShow
|
|
|
|
|
|
def test_plots_diff(dvc, mocker):
|
|
cli_args = parse_args(
|
|
[
|
|
"plots",
|
|
"diff",
|
|
"--out",
|
|
"result.extension",
|
|
"-t",
|
|
"template",
|
|
"--targets",
|
|
"datafile",
|
|
"--show-vega",
|
|
"-x",
|
|
"x_field",
|
|
"-y",
|
|
"y_field",
|
|
"--title",
|
|
"my_title",
|
|
"--x-label",
|
|
"x_title",
|
|
"--y-label",
|
|
"y_title",
|
|
"--experiment",
|
|
"HEAD",
|
|
"tag1",
|
|
"tag2",
|
|
]
|
|
)
|
|
assert cli_args.func == CmdPlotsDiff
|
|
|
|
cmd = cli_args.func(cli_args)
|
|
m = mocker.patch(
|
|
"dvc.repo.plots.diff.diff", return_value={"datafile": "filledtemplate"}
|
|
)
|
|
|
|
assert cmd.run() == 0
|
|
|
|
m.assert_called_once_with(
|
|
cmd.repo,
|
|
targets=["datafile"],
|
|
revs=["HEAD", "tag1", "tag2"],
|
|
props={
|
|
"template": "template",
|
|
"x": "x_field",
|
|
"y": "y_field",
|
|
"title": "my_title",
|
|
"x_label": "x_title",
|
|
"y_label": "y_title",
|
|
},
|
|
experiment=True,
|
|
)
|
|
|
|
|
|
def test_plots_show_vega(dvc, mocker):
|
|
cli_args = parse_args(
|
|
[
|
|
"plots",
|
|
"show",
|
|
"-o",
|
|
"result.extension",
|
|
"-t",
|
|
"template",
|
|
"--show-vega",
|
|
"--no-header",
|
|
"datafile",
|
|
]
|
|
)
|
|
assert cli_args.func == CmdPlotsShow
|
|
|
|
cmd = cli_args.func(cli_args)
|
|
|
|
m = mocker.patch(
|
|
"dvc.repo.plots.Plots.show",
|
|
return_value={"datafile": "filledtemplate"},
|
|
)
|
|
|
|
assert cmd.run() == 0
|
|
|
|
m.assert_called_once_with(
|
|
targets=["datafile"],
|
|
props={"template": "template", "header": False},
|
|
)
|
|
|
|
|
|
def test_plots_diff_vega(dvc, mocker, capsys):
|
|
cli_args = parse_args(
|
|
[
|
|
"plots",
|
|
"diff",
|
|
"HEAD~10",
|
|
"HEAD~1",
|
|
"--show-vega",
|
|
"--targets",
|
|
"plots.csv",
|
|
]
|
|
)
|
|
cmd = cli_args.func(cli_args)
|
|
mocker.patch(
|
|
"dvc.repo.plots.diff.diff", return_value={"plots.csv": "plothtml"}
|
|
)
|
|
assert cmd.run() == 0
|
|
|
|
out, _ = capsys.readouterr()
|
|
assert "plothtml" in out
|
|
|
|
|
|
def test_plots_diff_open(tmp_dir, dvc, mocker, capsys):
|
|
mocked_open = mocker.patch("webbrowser.open", return_value=True)
|
|
cli_args = parse_args(["plots", "diff", "--targets", "datafile", "--open"])
|
|
cmd = cli_args.func(cli_args)
|
|
mocker.patch(
|
|
"dvc.repo.plots.diff.diff", return_value={"datafile": "filledtemplate"}
|
|
)
|
|
|
|
assert cmd.run() == 0
|
|
mocked_open.assert_called_once_with("plots.html")
|
|
|
|
expected_url = posixpath.join(tmp_dir.as_uri(), "plots.html")
|
|
|
|
out, _ = capsys.readouterr()
|
|
assert expected_url in out
|
|
|
|
|
|
def test_plots_diff_open_failed(tmp_dir, dvc, mocker, capsys):
|
|
mocked_open = mocker.patch("webbrowser.open", return_value=False)
|
|
cli_args = parse_args(["plots", "diff", "--targets", "datafile", "--open"])
|
|
cmd = cli_args.func(cli_args)
|
|
mocker.patch(
|
|
"dvc.repo.plots.diff.diff", return_value={"datafile": "filledtemplate"}
|
|
)
|
|
|
|
assert cmd.run() == 1
|
|
mocked_open.assert_called_once_with("plots.html")
|
|
|
|
error_message = "Failed to open. Please try opening it manually."
|
|
expected_url = posixpath.join(tmp_dir.as_uri(), "plots.html")
|
|
|
|
out, err = capsys.readouterr()
|
|
assert expected_url in out
|
|
assert error_message in err
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"output, expected_url_path",
|
|
[
|
|
("plots file with spaces.html", "plots%20file%20with%20spaces.html"),
|
|
(os.path.join("dir", "..", "plots.html"), "plots.html"),
|
|
],
|
|
ids=["quote", "resolve"],
|
|
)
|
|
def test_plots_path_is_quoted_and_resolved_properly(
|
|
tmp_dir, dvc, mocker, capsys, output, expected_url_path
|
|
):
|
|
cli_args = parse_args(
|
|
["plots", "diff", "--targets", "datafile", "--out", output]
|
|
)
|
|
cmd = cli_args.func(cli_args)
|
|
mocker.patch(
|
|
"dvc.repo.plots.diff.diff", return_value={"datafile": "filledtemplate"}
|
|
)
|
|
|
|
assert cmd.run() == 0
|
|
expected_url = posixpath.join(tmp_dir.as_uri(), expected_url_path)
|
|
|
|
out, _ = capsys.readouterr()
|
|
assert expected_url in out
|