exp run: remove exp reset in favor of exp run --reset (#5442)

* exp run: remove `exp reset` in favor of `exp run --reset`

* update command unit test
This commit is contained in:
Peter Rowlands (변기호)
2021-02-11 11:53:20 +09:00
committed by GitHub
parent 9d82739b3a
commit e3ee960e8e
2 changed files with 6 additions and 33 deletions
+3 -27
View File
@@ -924,36 +924,12 @@ def add_parser(subparsers, parent_parser):
metavar="<experiment_rev>",
)
experiments_run_parser.add_argument(
"--reset", action="store_true", help=argparse.SUPPRESS,
"--reset",
action="store_true",
help="Reset existing checkpoints and restart the experiment.",
)
experiments_run_parser.set_defaults(func=CmdExperimentsRun)
EXPERIMENTS_RESET_HELP = "Reset and restart checkpoint experiments."
experiments_reset_parser = experiments_subparsers.add_parser(
"reset",
parents=[parent_parser],
description=append_doc_link(EXPERIMENTS_RESET_HELP, "exp/reset"),
help=EXPERIMENTS_RESET_HELP,
formatter_class=argparse.RawDescriptionHelpFormatter,
)
experiments_reset_parser.add_argument(
"-r",
"--rev",
type=str,
default=None,
dest="checkpoint_resume",
help=argparse.SUPPRESS,
)
_add_run_common(experiments_reset_parser)
experiments_reset_parser.add_argument(
"--reset",
action="store_const",
const=True,
default=True,
help=argparse.SUPPRESS,
)
experiments_reset_parser.set_defaults(func=CmdExperimentsRun)
EXPERIMENTS_GC_HELP = "Garbage collect unneeded experiments."
EXPERIMENTS_GC_DESCRIPTION = (
"Removes all experiments which are not derived from the specified"
+3 -6
View File
@@ -87,10 +87,7 @@ def test_experiments_show(dvc, scm, mocker):
)
@pytest.mark.parametrize(
"args, reset", [(["exp", "run"], False), (["exp", "reset"], True)],
)
def test_experiments_run(dvc, scm, mocker, args, reset):
def test_experiments_run(dvc, scm, mocker):
default_arguments = {
"params": [],
"name": None,
@@ -99,11 +96,11 @@ def test_experiments_run(dvc, scm, mocker, args, reset):
"jobs": None,
"tmp_dir": False,
"checkpoint_resume": None,
"reset": reset,
"reset": False,
}
default_arguments.update(repro_arguments)
cmd = CmdExperimentsRun(parse_args(args))
cmd = CmdExperimentsRun(parse_args(["exp", "run"]))
mocker.patch.object(cmd.repo, "reproduce")
mocker.patch.object(cmd.repo.experiments, "run")
cmd.run()