Stone_Red/dvc
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/dvc.git synced 2026-11-13 15:28:27 +01:00
Code Issues Packages Projects Releases Wiki Activity

param: Fix status check for Tuples.

Browse Source 
Closes #8803

Update dvc/dependency/param.py

Co-authored-by: Peter Rowlands (변기호) <[email protected]>
This commit is contained in:
David de la Iglesia Castro
2023-01-19 08:19:16 +01:00
co-authored by Peter Rowlands
parent 5f558d003a
commit dd2d2dce19
2 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dvc/dependency/param.py
+7 -2
View File
@@ -125,9 +125,14 @@ class ParamsDependency(Dependency):
elif param not in info:
st = "new"
elif actual[param] != info[param]:
st = "modified"
if (
isinstance(actual[param], tuple)
and list(actual[param]) == info[param]
):
continue
else:
st = "modified"
else:
assert actual[param] == info[param]
continue
status[str(self)][param] = st
tests/unit/dependency/test_params.py
+16
View File
@@ -207,6 +207,22 @@ def test_read_params_py(tmp_dir, dvc):
assert dep.read_params() == {"x": 4, "Klass.a": "val1"}
def test_params_py_tuple_status(tmp_dir, dvc):
"""https://github.com/iterative/dvc/issues/8803"""
parameters_file = "parameters.py"
tmp_dir.gen(parameters_file, "TUPLE = (10, 100)\n")
dep = ParamsDependency(Stage(dvc), parameters_file, ["TUPLE"])
# lock file uses YAML so the tuple will be loaded as a list
dep.fill_values({"TUPLE": [10, 100]})
assert dep.status() == {}
dep.fill_values({"TUPLE": [11, 100]})
assert dep.status() == {"parameters.py": {"TUPLE": "modified"}}
dep.fill_values({"TUPLE": [10]})
assert dep.status() == {"parameters.py": {"TUPLE": "modified"}}
dep.fill_values({"TUPLE": {10: "foo", 100: "bar"}})
assert dep.status() == {"parameters.py": {"TUPLE": "modified"}}
def test_get_hash_missing_config(dvc):
dep = ParamsDependency(Stage(dvc), None, ["foo"])
with pytest.raises(MissingParamsError):