Merge pull request #2071 from mroutis/progress-be-quiet

progress: bug fix with --quiet

dvc/progress.py

@@ -111,7 +111,7 @@ class Progress(object):
 
         logger = logging.getLogger(__name__)
 
-        if logger.getEffectiveLevel() == "CRITICAL":
+        if logger.getEffectiveLevel() == logging.CRITICAL:
             return
 
         print(*args, **kwargs)

tests/unit/test_progress.py

@@ -1,14 +1,19 @@
+import logging
 import mock
-from unittest import TestCase
-
-from dvc.progress import ProgressCallback
+from dvc.progress import progress, ProgressCallback
 
 
-class TestProgressCallback(TestCase):
+def test_quiet(caplog, capsys):
+    with caplog.at_level(logging.CRITICAL, logger="dvc"):
+        progress._print("something")
+        assert capsys.readouterr().out == ""
+
+
+class TestProgressCallback:
     @mock.patch("dvc.progress.progress")
     def test_should_init_reset_progress(self, progress_mock):
         total_files_num = 1
 
         ProgressCallback(total_files_num)
 
-        self.assertEqual([mock.call.reset()], progress_mock.method_calls)
+        assert [mock.call.reset()] == progress_mock.method_calls