repro: introduce --prompt

Fixes #894

Signed-off-by: Ruslan Kuprieiev <[email protected]>
This commit is contained in:
Ruslan Kuprieiev
2018-08-05 00:21:35 +03:00
parent ed8052c229
commit aab04a22ad
4 changed files with 36 additions and 9 deletions
+7
View File
@@ -330,6 +330,13 @@ def parse_args(argv=None):
default=False,
help='Only print the commands that would be executed '
'without actually executing.')
repro_parser.add_argument(
'-i',
'--interactive',
action='store_true',
default=False,
help='Ask for confirmation before reproducing each '
'stage.')
repro_parser.set_defaults(func=CmdRepro)
# Remove
+2 -1
View File
@@ -18,7 +18,8 @@ class CmdRepro(CmdBase):
self.project.reproduce(target,
recursive=recursive,
force=self.args.force,
dry=self.args.dry)
dry=self.args.dry,
interactive=self.args.interactive)
if self.args.metrics:
self.project.metrics_show()
except ReproductionError as ex:
+21 -7
View File
@@ -235,7 +235,7 @@ class Project(object):
stage.dump()
return stage
def _reproduce_stage(self, stages, node, force, dry):
def _reproduce_stage(self, stages, node, force, dry, interactive):
stage = stages[node]
if stage.locked:
@@ -243,7 +243,7 @@ class Project(object):
'going to be reproduced.'
self.logger.warn(msg.format(stage.relpath))
stage = stage.reproduce(force=force, dry=dry)
stage = stage.reproduce(force=force, dry=dry, interactive=interactive)
if not stage:
return []
@@ -252,7 +252,12 @@ class Project(object):
return [stage]
def reproduce(self, target, recursive=True, force=False, dry=False):
def reproduce(self,
target,
recursive=True,
force=False,
dry=False,
interactive=False):
import networkx as nx
G = self.graph()[1]
@@ -262,17 +267,26 @@ class Project(object):
raise NotDvcFileError(target)
if recursive:
return self._reproduce_stages(G, stages, node, force, dry)
return self._reproduce_stages(G,
stages,
node,
force,
dry,
interactive)
return self._reproduce_stage(stages, node, force, dry)
return self._reproduce_stage(stages, node, force, dry, interactive)
def _reproduce_stages(self, G, stages, node, force, dry):
def _reproduce_stages(self, G, stages, node, force, dry, interactive):
import networkx as nx
result = []
for n in nx.dfs_postorder_nodes(G, node):
try:
result += self._reproduce_stage(stages, n, force, dry)
result += self._reproduce_stage(stages,
n,
force,
dry,
interactive)
except Exception as ex:
raise ReproductionError(stages[n].relpath, ex)
return result
+6 -1
View File
@@ -150,7 +150,7 @@ class Stage(object):
self.remove_outs(ignore_remove=True)
os.unlink(self.path)
def reproduce(self, force=False, dry=False):
def reproduce(self, force=False, dry=False, interactive=False):
if not self.changed() and not force:
return None
@@ -158,6 +158,11 @@ class Stage(object):
# Removing outputs only if we actually have command to reproduce
self.remove_outs(ignore_remove=False)
msg = "Going to reproduce '{}'. Are you sure you want to continue?"
msg = msg.format(self.relpath)
if interactive and not prompt(msg):
raise DvcException('Reproduction aborted by the user')
self.project.logger.info(u'Reproducing \'{}\''.format(self.relpath))
self.run(dry=dry)