Merge pull request #2821 from kaiogu/master

remote: fix remote default call with no arguments
This commit is contained in:
Ruslan Kuprieiev
2019-11-26 20:37:31 +02:00
committed by GitHub
3 changed files with 19 additions and 3 deletions
+7 -3
View File
@@ -48,9 +48,13 @@ class CmdRemoteModify(CmdRemoteConfig):
class CmdRemoteDefault(CmdRemoteConfig):
def run(self):
self.remote_config.set_default(
self.args.name, unset=self.args.unset, level=self.args.level
)
if self.args.name is None and not self.args.unset:
name = self.remote_config.get_default(level=self.args.level)
print(name)
else:
self.remote_config.set_default(
self.args.name, unset=self.args.unset, level=self.args.level
)
return 0
+5
View File
@@ -151,3 +151,8 @@ class RemoteConfig(object):
self.config.set(
Config.SECTION_CORE, Config.SECTION_CORE_REMOTE, name, level=level
)
def get_default(self, level=None):
return self.config.get(
Config.SECTION_CORE, Config.SECTION_CORE_REMOTE, level=level
)
+7
View File
@@ -145,6 +145,13 @@ class TestRemoteDefault(TestDvc):
self.assertEqual(default, None)
def test_show_default(dvc_repo, capsys):
assert main(["remote", "default", "foo"]) == 0
assert main(["remote", "default"]) == 0
out, _ = capsys.readouterr()
assert out == "foo\n"
class TestRemoteShouldHandleUppercaseRemoteName(TestDvc):
upper_case_remote_name = "UPPERCASEREMOTE"