Stone_Red/dvc
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/dvc.git synced 2026-11-02 07:18:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(plots): handle empty directories (#10344)

Browse Source 
* fix(plots): handle empty directories

* Update tests/integration/plots/test_plots.py

Co-authored-by: skshetry <[email protected]>

* cleanup after review

---------

Co-authored-by: skshetry <[email protected]>
This commit is contained in:
Ivan Shcheklein
2024-03-07 12:50:49 +05:45
committed by GitHub
co-authored by skshetry
parent cf9855af45
commit 9957410998
2 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dvc/repo/plots/__init__.py
+6 -5
View File
@@ -462,11 +462,12 @@ def _resolve_definitions(
fs, data_path, props=plot_props | props, onerror=onerror
)
# use config for parent directory with most specific definition
unpacked["data"] = {
k: v
for k, v in unpacked["data"].items()
if _closest_parent(fs, k, plot_ids_parents) == data_path
}
if unpacked.get("data"):
unpacked["data"] = {
k: v
for k, v in unpacked["data"].items()
if _closest_parent(fs, k, plot_ids_parents) == data_path
}
dpath.merge(result, unpacked)
elif _matches(targets, config_path, plot_id):
adjusted_props = _adjust_sources(fs, plot_props, config_dir)
tests/integration/plots/test_plots.py
+12
View File
@@ -634,3 +634,15 @@ def test_nested_x_defn_collection(tmp_dir, dvc, scm, capsys):
{"step": 1, "Max_Leaf_Nodes": "50", "rev": "workspace"},
{"step": 2, "Max_Leaf_Nodes": "500", "rev": "workspace"},
]
def test_plots_empty_directory(tmp_dir, dvc, scm, capsys):
(tmp_dir / "empty").mkdir()
(tmp_dir / "dvc.yaml").dump({"plots": [{"empty": {}}]})
scm.add(["dvc.yaml"])
scm.commit("commit dvc files")
html_path, _, split_json_result = call(capsys)
assert split_json_result == {}
assert html_path == ""