exp save: add recursive arg

This commit is contained in:
dberenbaum
2024-01-19 12:57:27 +09:00
committed by Peter Rowlands (변기호)
parent 48ec86de28
commit 71afff6db3
4 changed files with 23 additions and 11 deletions
+9 -8
View File
@@ -16,6 +16,7 @@ class CmdExperimentsSave(CmdBase):
ref = self.repo.experiments.save(
targets=self.args.targets,
name=self.args.name,
recursive=self.args.recursive,
force=self.args.force,
include_untracked=self.args.include_untracked,
message=self.args.message,
@@ -45,15 +46,15 @@ def add_parser(experiments_subparsers, parent_parser):
save_parser.add_argument(
"targets",
nargs="*",
help="""\
Stages to save. 'dvc.yaml' by default.
The targets can be path to a dvc.yaml file or `.dvc` file,
or a stage name from dvc.yaml file from
current working directory. To save a stage from dvc.yaml
from other directories, the target must be a path followed by colon `:`
and then the stage name name.
""",
help=("Limit DVC caching to these .dvc files and stage names."),
).complete = completion.DVCFILES_AND_STAGE
save_parser.add_argument(
"-R",
"--recursive",
action="store_true",
default=False,
help="Cache subdirectories of the specified directory.",
)
save_parser.add_argument(
"-f",
"--force",
+7 -2
View File
@@ -269,6 +269,7 @@ class BaseExecutor(ABC):
cls,
info: "ExecutorInfo",
targets: Optional[Iterable[str]] = None,
recursive: bool = False,
force: bool = False,
include_untracked: Optional[List[str]] = None,
message: Optional[str] = None,
@@ -297,9 +298,13 @@ class BaseExecutor(ABC):
stages = []
if targets:
for target in targets:
stages.append(dvc.commit(target, force=True, relink=False))
stages.append(
dvc.commit(
target, recursive=recursive, force=True, relink=False
)
)
else:
stages = dvc.commit([], force=True, relink=False)
stages = dvc.commit([], recursive=recursive, force=True, relink=False)
exp_hash = cls.hash_exp(stages)
if include_untracked:
dvc.scm.add(include_untracked, force=True) # type: ignore[call-arg]
+2
View File
@@ -16,6 +16,7 @@ def save(
repo: "Repo",
targets: Optional[Iterable[str]] = None,
name: Optional[str] = None,
recursive: bool = False,
force: bool = False,
include_untracked: Optional[List[str]] = None,
message: Optional[str] = None,
@@ -34,6 +35,7 @@ def save(
save_result = executor.save(
executor.info,
targets=targets,
recursive=recursive,
force=force,
include_untracked=include_untracked,
message=message,
+5 -1
View File
@@ -475,7 +475,9 @@ def test_experiments_rename_invalid(dvc, scm, mocker, capsys, caplog):
def test_experiments_save(dvc, scm, mocker):
cli_args = parse_args(["exp", "save", "target", "--name", "exp-name", "--force"])
cli_args = parse_args(
["exp", "save", "target", "--name", "exp-name", "--recursive", "--force"]
)
assert cli_args.func == CmdExperimentsSave
cmd = cli_args.func(cli_args)
@@ -487,6 +489,7 @@ def test_experiments_save(dvc, scm, mocker):
cmd.repo,
targets=["target"],
name="exp-name",
recursive=True,
force=True,
include_untracked=[],
message=None,
@@ -507,6 +510,7 @@ def test_experiments_save_message(dvc, scm, mocker, flag):
cmd.repo,
targets=[],
name=None,
recursive=False,
force=False,
include_untracked=[],
message="custom commit message",