Stone_Red/dvc
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/dvc.git synced 2026-11-02 07:18:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3129 from mroutis/fix-version

Browse Source 
version: decode correctly commands output
This commit is contained in:
Ruslan Kuprieiev
2020-01-14 10:20:12 +02:00
committed by GitHub
parent efa655ecf1 2c9b763906
commit 563f75ebf7
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dvc/version.py
+1 -1
View File
@@ -49,7 +49,7 @@ def _is_release(dir_path, base_version):
["git", "describe", "--tags", "--exact-match"],
cwd=dir_path,
stderr=subprocess.STDOUT,
)
).decode("utf-8")
tag = output.strip()
return tag == base_version
except subprocess.CalledProcessError:
tests/unit/test_version.py
+2 -2
View File
@@ -12,10 +12,10 @@ def test_is_release():
assert ret is False
m.side_effect = None
m.return_value = dvc.version._BASE_VERSION
m.return_value = dvc.version._BASE_VERSION.encode("ascii")
ret = dvc.version._is_release(None, dvc.version._BASE_VERSION)
assert ret
m.return_value = "630d1741c2d5dd89a3176bd15b63121b905d35c9"
m.return_value = b"630d1741c2d5dd89a3176bd15b63121b905d35c9"
ret = dvc.version._is_release(None, dvc.version._BASE_VERSION)
assert ret is False