metrics: show: remove active branch from tags only show call

This commit is contained in:
pared
2019-06-18 15:28:51 +02:00
committed by pawel
parent c023b8da57
commit 38642eb127
2 changed files with 26 additions and 0 deletions
+3
View File
@@ -269,6 +269,9 @@ def show(
if metrics:
res[branch] = metrics
if all_tags and not all_branches:
res.pop(repo.scm.active_branch())
if not res:
if path:
raise BadMetricError(path)
+23
View File
@@ -829,3 +829,26 @@ class TestShouldDisplayMetricsEvenIfMetricIsMissing(object):
in caplog.text
)
assert 0 == ret
def test_should_not_display_current_branch_on_display_tag(
git, dvc_repo, repo_dir
):
def write_metric_code(metric_filename, metric_value):
return "with open('{}', 'w') as fobj:\n fobj.write('{}')".format(
metric_filename, metric_value
)
metric_filename = "metric"
metric_stage = metric_filename + Stage.STAGE_FILE_SUFFIX
code = write_metric_code(metric_filename, 0.5)
run_command = 'python -c "{}"'
dvc_repo.run(cmd=run_command.format(code), metrics=[metric_filename])
git.index.add([metric_filename, metric_stage])
git.index.commit("first")
tag = "v1.0"
git.git.tag(tag)
metrics = dvc_repo.metrics.show(all_tags=True)
assert set(metrics.keys()) == {tag}