Merge pull request #1182 from efiop/master

gc: add a comfirmation prompt

dvc/cli.py

@@ -541,6 +541,12 @@ def parse_args(argv=None):
                         '-r',
                         '--remote',
                         help='Remote repository to collect garbage in.')
+    gc_parser.add_argument(
+                        '-f',
+                        '--force',
+                        action='store_true',
+                        default=False,
+                        help='Force garbage collection.')
     gc_parser.set_defaults(func=CmdGC)
 
     # Config

dvc/command/gc.py

@@ -3,6 +3,22 @@ from dvc.command.base import CmdBase
 
 class CmdGC(CmdBase):
     def run(self):
+        msg = 'This will remove all cache except the cache that is used in '
+        if not self.args.all_branches and not self.args.all_tags:
+            msg += 'the current git branch.'
+        elif self.args.all_branches and not self.args.all_tags:
+            msg += 'all git branches.'
+        elif not self.args.all_branches and self.args.all_tags:
+            msg += 'all git tags.'
+        else:
+            msg += 'all git branches and all git tags.'
+
+        self.project.logger.warn(msg)
+
+        msg = 'Are you sure you want to proceed?'
+        if not self.args.force and not self.project.prompt.prompt(msg):
+            return 1
+
         self.project.gc(all_branches=self.args.all_branches,
                         all_tags=self.args.all_tags,
                         cloud=self.args.cloud,

tests/test_gc.py

@@ -29,7 +29,8 @@ class TestGC(TestDvc):
         self._test_gc()
 
     def test_cli(self):
-        ret = main(['gc'])
+        ret = main(['gc', '-f'])
+        self.assertEqual(ret, 0)
         self._test_gc()
 
     def _test_gc(self):