tests: win: don't cleanup processes on Popen

Workaround for two bugs: https://bugs.python.org/issue37380 and https://github.com/gitpython-developers/GitPython/issues/546 Signed-off-by: Ruslan Kuprieiev <[email protected]>
2026-11-10 07:18:27 +01:00 · 2019-06-23 22:35:50 +03:00
parent 2a4d6229b1
commit 1cb70fc631
2 changed files with 22 additions and 0 deletions
@@ -3,8 +3,30 @@ import os
 # Increasing fd ulimit for tests
 if os.name == "nt":
    import win32file
+    import subprocess

    win32file._setmaxstdio(2048)
+
+    # Workaround for two bugs:
+    #
+    # 1) gitpython-developers/GitPython#546
+    # GitPython leaves git cat-file --batch/--batch-check processes that are
+    # not cleaned up correctly, so Popen._active list has their defunct
+    # process handles, that it is not able to cleanup because of bug 2)
+    #
+    # 2) https://bugs.python.org/issue37380
+    # subprocess.Popen._internal_poll on windows is getting
+    #
+    # 	OSError: [WinError 6] The handle is invalid
+    #
+    # exception, which it doesn't ignore and so Popen is not able to cleanup
+    # old processes and that prevents it from creating any new processes at
+    # all, which results in our tests failing whenever they try to use Popen.
+
+    def noop():
+        pass
+
+    subprocess._cleanup = noop
 else:
    import resource