[PR #37] [MERGED] fix: when users clicks public -> private -> public checkbox in the channel creation, it ends up creating the channel on 3rd check switch #37

New Issue

2026-09-04T00:49:48+02:00

Stone_Red commented

2026-09-04 00:49:48 +02:00

📋 Pull Request Information

Original PR: https://github.com/RedWizardsLab/EchoHub/pull/37
Author: @Stone-Red-Code
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @Stone-Red-Code

Base: dev ← Head: dev_fix_create_dialog_checkbox

📝 Commits (2)

3f2211f fix: double click on public checkbox creates channel by setting set CommandsToBubbleUp in dialog
38d63d8 chore: mark checkbox issue in channel creation as completed in todo list

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 docs/todo.md (+1 -1)
📝 src/EchoHub.Client/EchoHub.Client.csproj (+1 -1)
📝 src/EchoHub.Client/UI/Dialogs/CreateChannelDialog.cs (+1 -1)

📄 Description

Summary

Fixes: https://github.com/HueByte/EchoHub/blob/082081973825202a69cb63f662e61c81e15b8c44/docs/todo.md?plain=1#L18

This was a bug in Terminal.Gui, which was recently fixed by introducing the CommandsToBubbleUp property to control which commands bubble up a view, if a control doesn't handle it. (In this case the CheckBox doesn't handle Command.Accept)

https://github.com/gui-cs/Terminal.Gui/pull/4620

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RedWizardsLab/EchoHub/pull/37 **Author:** [@Stone-Red-Code](https://github.com/Stone-Red-Code) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@Stone-Red-Code](https://github.com/Stone-Red-Code) **Base:** `dev` ← **Head:** `dev_fix_create_dialog_checkbox` --- ### 📝 Commits (2) - [`3f2211f`](https://github.com/RedWizardsLab/EchoHub/commit/3f2211f42aa43939ff1b84f17eea53cb636b4ae6) fix: double click on public checkbox creates channel by setting set CommandsToBubbleUp in dialog - [`38d63d8`](https://github.com/RedWizardsLab/EchoHub/commit/38d63d844d7894b0fb5520c17933157c4826c3bf) chore: mark checkbox issue in channel creation as completed in todo list ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/todo.md` (+1 -1) 📝 `src/EchoHub.Client/EchoHub.Client.csproj` (+1 -1) 📝 `src/EchoHub.Client/UI/Dialogs/CreateChannelDialog.cs` (+1 -1) </details> ### 📄 Description # Summary Fixes: https://github.com/HueByte/EchoHub/blob/082081973825202a69cb63f662e61c81e15b8c44/docs/todo.md?plain=1#L18 This was a bug in Terminal.Gui, which was recently fixed by introducing the `CommandsToBubbleUp` property to control which commands bubble up a view, if a control doesn't handle it. (In this case the `CheckBox` doesn't handle `Command.Accept`) https://github.com/gui-cs/Terminal.Gui/pull/4620 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

Stone_Red added the pull-request label 2026-09-04 00:49:48 +02:00

Stone_Red closed this issue

2026-09-04 00:49:48 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RedWizardsLab/EchoHub#37