[PR #15] [MERGED] Fix the error where the code doesn't compile #58

Closed
opened 2026-09-04 00:21:55 +02:00 by Stone_Red · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/detleph/server/pull/15
Author: @stephan418
Created: 11/9/2021
Status: Merged
Merged: 11/10/2021
Merged by: @stephan418

Base: mainHead: fix-superagent


📝 Commits (1)

  • f2e18e1 Fix the error where the code doesn't compile

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

src/superagent.d.ts (+3 -0)

📄 Description

TypeScript is not used for browser development here, hence it does not know the type XMLHttpRequest (used by SuperAgent)
This is not an ideal solution and we should look into a better solution (maybe add the "dom" lib in tsconfig.json)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/detleph/server/pull/15 **Author:** [@stephan418](https://github.com/stephan418) **Created:** 11/9/2021 **Status:** ✅ Merged **Merged:** 11/10/2021 **Merged by:** [@stephan418](https://github.com/stephan418) **Base:** `main` ← **Head:** `fix-superagent` --- ### 📝 Commits (1) - [`f2e18e1`](https://github.com/detleph/server/commit/f2e18e165646ee1f45be023b5e0ad1b8bf5e1c82) Fix the error where the code doesn't compile ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `src/superagent.d.ts` (+3 -0) </details> ### 📄 Description TypeScript is not used for browser development here, hence it does not know the type XMLHttpRequest (used by SuperAgent) This is not an ideal solution and we should look into a better solution (maybe add the "dom" lib in tsconfig.json) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Stone_Red added the pull-request label 2026-09-04 00:21:55 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: detleph/server#58