detleph/server
1
0
Fork 0
mirror of https://github.com/detleph/server.git synced 2026-09-04 00:26:03 +02:00
Code Issues 9 Packages Projects Releases Wiki Activity

[GH-ISSUE #65] Routes are non-standard #29

New Issue
Closed
opened 2026-09-04 00:21:41 +02:00 by Stone_Red · 1 comment
Stone_Red commented 2026-09-04 00:21:41 +02:00
Owner
Copy Link
Copy Source

Originally created by @stephan418 on GitHub (Jun 1, 2022).
Original GitHub issue: https://github.com/detleph/server/issues/65

https://github.com/detleph/server/blob/eff81e32f1b2ce6c30f2128d439c5b16550f1f84/src/Routes/participant.routes.ts#L16

The PID is specified after /teams but represents a participant?
Wouldn't /participants/:pid or /teams/:teamPid/participants/:pid make more sense?

Also: please use participants instead of participant (collections are always plural)

Originally created by @stephan418 on GitHub (Jun 1, 2022). Original GitHub issue: https://github.com/detleph/server/issues/65 https://github.com/detleph/server/blob/eff81e32f1b2ce6c30f2128d439c5b16550f1f84/src/Routes/participant.routes.ts#L16 The PID is specified after /teams but represents a participant? Wouldn't /participants/:pid or /teams/:teamPid/participants/:pid make more sense? Also: please use participants instead of participant (collections are always plural)
Stone_Red commented 2026-09-04 00:21:42 +02:00
Author
Owner
Copy Link
Copy Source

@Flexla54 commented on GitHub (Jun 6, 2022):

Done

<!-- gh-comment-id:1147667659 --> @Flexla54 commented on GitHub (Jun 6, 2022): Done
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
enhancement
feature
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 question
release
urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Stone_Red
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: detleph/server#29