There is no confidential information in the build (As the whole code could be made public)
Make sure that everything but reads is currently only available to admins
Review the authorization code and the media code again (As those are likely the most vulnerable)
Add CORS
(The prod server should be able to be deployed with this release tomorrow)
Minium feature requirement for the release (C for Create, R for Read, U for Update, D for Delete):
Auth (C)
Events (R)
Disciplines (R)
RoleSchemas (R)
Organisation (R)
Group (R)
Originally created by @stephan418 on GitHub (May 15, 2022).
Original GitHub issue: https://github.com/detleph/server/issues/48
Originally assigned to: @Stefan-5422 on GitHub.
And merge it into the main branch for deployment
Please make sure that:
- [x] Everything is working as expected (Docker, FS and so on)
- [x] Logging code is turned to production mode (With the NODE_ENV variable)
- [ ] #97
- [x] The default admin is removed from app.ts (!!)
- [x] The minimum required features are working (Tho CRUD should be working for all of them except if something went terribly wrong)
- [x] #49
- [x] There is no confidential information in the build (As the whole code could be made public)
- [x] Make sure that everything but reads is currently only available to admins
- [x] Review the authorization code and the media code again (As those are likely the most vulnerable)
- [x] Add CORS
(The prod server should be able to be deployed with this release tomorrow)
Minium feature requirement for the release (C for Create, R for Read, U for Update, D for Delete):
- Auth (C)
- Events (R)
- Disciplines (R)
- RoleSchemas (R)
- Organisation (R)
- Group (R)
I looked over most of the code we are using and have not found any obvious security issues. Maybe I'm blind tho
<!-- gh-comment-id:1129258823 -->
@Stefan-5422 commented on GitHub (May 17, 2022):
> Everything is checked for unsafe code
I looked over most of the code we are using and have not found any obvious security issues. Maybe I'm blind tho
Logging code is turned to production mode (With the NODE_ENV variable)
This will need to be done on the server and shall be remembered
<!-- gh-comment-id:1129261057 -->
@Stefan-5422 commented on GitHub (May 17, 2022):
> Logging code is turned to production mode (With the NODE_ENV variable)
This will need to be done on the server and shall be remembered
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @stephan418 on GitHub (May 15, 2022).
Original GitHub issue: https://github.com/detleph/server/issues/48
Originally assigned to: @Stefan-5422 on GitHub.
And merge it into the main branch for deployment
Please make sure that:
(The prod server should be able to be deployed with this release tomorrow)
Minium feature requirement for the release (C for Create, R for Read, U for Update, D for Delete):
@stephan418 commented on GitHub (May 16, 2022):
Media is now working
@Stefan-5422 commented on GitHub (May 17, 2022):
I looked over most of the code we are using and have not found any obvious security issues. Maybe I'm blind tho
@Stefan-5422 commented on GitHub (May 17, 2022):
This will need to be done on the server and shall be remembered
@stephan418 commented on GitHub (Dec 8, 2022):
Everything resolved or moved;