From de7e06eb2adccf066ee905cc7e01d36aa4406e95 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Wed, 4 Sep 2019 22:47:03 -0400 Subject: [PATCH 1/4] fix: missed type after refactor --- src/components/Markdown/index.tsx | 2 +- src/components/ResourceHeader/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/Markdown/index.tsx b/src/components/Markdown/index.tsx index b5e166c..a6a2aa7 100644 --- a/src/components/Markdown/index.tsx +++ b/src/components/Markdown/index.tsx @@ -17,7 +17,7 @@ interface IMarkdownProps { export function Markdown({ content, ...restProps -}: MarkdownProps): JSX.Element { +}: IMarkdownProps): JSX.Element { React.useEffect(() => { Prism.highlightAll() }, []) diff --git a/src/components/ResourceHeader/index.tsx b/src/components/ResourceHeader/index.tsx index c73bcba..3fa8e83 100644 --- a/src/components/ResourceHeader/index.tsx +++ b/src/components/ResourceHeader/index.tsx @@ -51,7 +51,7 @@ export function ResourceHeader({ timeToRead, recommendedReading, externalResources, -}: ResourceHeaderProps) { +}: IResourceHeaderProps) { const date = new Date(createdAt) const month = date.toLocaleString("default", { month: "long" }) const day = date.getDate() From f32bdb549da4fd3bc9fb6bfbe08f6df4cb0f0370 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Wed, 4 Sep 2019 22:49:07 -0400 Subject: [PATCH 2/4] style: remove console.log leftover from dev --- src/templates/languagePost.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/templates/languagePost.tsx b/src/templates/languagePost.tsx index 06e326a..dd642fe 100644 --- a/src/templates/languagePost.tsx +++ b/src/templates/languagePost.tsx @@ -8,7 +8,7 @@ import { SEO } from "../components/SEO" function LanguagePost({ data }: any) { const { relativePath } = data.file const { html, fields, frontmatter, timeToRead } = data.file.post - console.log(data) + return ( From 7d426bc21d022d143539e592319ca6c096ec0c8f Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Thu, 5 Sep 2019 01:15:01 -0400 Subject: [PATCH 3/4] refact: prefer named exports --- src/components/DiscordButton/index.tsx | 4 +--- src/components/Header/index.tsx | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/components/DiscordButton/index.tsx b/src/components/DiscordButton/index.tsx index d6c692a..0eed1a2 100644 --- a/src/components/DiscordButton/index.tsx +++ b/src/components/DiscordButton/index.tsx @@ -1,12 +1,10 @@ import React, { PropsWithChildren } from "react" import * as SC from "./styles" -function DiscordButton({ children }: PropsWithChildren<{}>) { +export function DiscordButton({ children }: PropsWithChildren<{}>) { return ( {children} ) } - -export default DiscordButton diff --git a/src/components/Header/index.tsx b/src/components/Header/index.tsx index 47e96c3..46ec8b1 100644 --- a/src/components/Header/index.tsx +++ b/src/components/Header/index.tsx @@ -1,6 +1,6 @@ import { Link } from "gatsby" import React, { PropsWithChildren, useLayoutEffect, useState } from "react" -import DiscordButton from "../DiscordButton" +import { DiscordButton } from "../DiscordButton" import { WavesBottom, WavesTop } from "../Waves" import * as SC from "./styles" From cd81e62d0c55f831f469b9c28cb6704feb164721 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Thu, 5 Sep 2019 01:34:42 -0400 Subject: [PATCH 4/4] refact: clean up unused variables & setup matching lint rule --- package.json | 2 +- src/components/Footer/styles.tsx | 1 - src/components/Layout/index.tsx | 10 ---------- src/pages/about.tsx | 2 +- src/pages/index.tsx | 1 - src/pages/rules.tsx | 2 +- tslint.json | 1 + 7 files changed, 4 insertions(+), 15 deletions(-) diff --git a/package.json b/package.json index fbc6a5e..8b13722 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "develop": "gatsby develop", "fetch-users": "node ./scripts/fetchUsers.js", "format": "prettier --write src/**/*.{js,jsx}", - "lint": "tslint -c tslint.json '{src,scripts}/**/*.{js,ts,tsx}'", + "lint": "tslint -p tsconfig.json -c tslint.json '{src,scripts}/**/*.{js,ts,tsx}'", "lint:fix": "npm run lint -- --fix", "serve": "gatsby serve", "start": "npm run develop", diff --git a/src/components/Footer/styles.tsx b/src/components/Footer/styles.tsx index 9b6039b..4588dd3 100644 --- a/src/components/Footer/styles.tsx +++ b/src/components/Footer/styles.tsx @@ -1,4 +1,3 @@ -import { Link } from "gatsby" import styled from "styled-components" export const FooterWrapper = styled.footer` diff --git a/src/components/Layout/index.tsx b/src/components/Layout/index.tsx index c899a70..ae18af2 100644 --- a/src/components/Layout/index.tsx +++ b/src/components/Layout/index.tsx @@ -5,7 +5,6 @@ * See: https://www.gatsbyjs.org/docs/use-static-query/ */ -import { graphql, useStaticQuery } from "gatsby" import React, { Fragment, PropsWithChildren } from "react" import { GlobalStyles } from "../../globalStyles" @@ -20,15 +19,6 @@ export function Layout({ location, }: PropsWithChildren<{ location: Location }>) { const isHome = location.pathname === "/" - const data = useStaticQuery(graphql` - query { - site { - siteMetadata { - title - } - } - } - `) return ( diff --git a/src/pages/about.tsx b/src/pages/about.tsx index 81c3e62..35b1d92 100644 --- a/src/pages/about.tsx +++ b/src/pages/about.tsx @@ -1,6 +1,6 @@ import { graphql } from "gatsby" import React, { Fragment } from "react" -import { MarkdownRemark, Query } from "../../generated/graphql" +import { MarkdownRemark } from "../../generated/graphql" import { Markdown } from "../components/Markdown" import { SEO } from "../components/SEO" diff --git a/src/pages/index.tsx b/src/pages/index.tsx index 36a3716..69384ca 100644 --- a/src/pages/index.tsx +++ b/src/pages/index.tsx @@ -1,4 +1,3 @@ -import { Link } from "gatsby" import React, { Fragment } from "react" import { SEO } from "../components/SEO" diff --git a/src/pages/rules.tsx b/src/pages/rules.tsx index 695cc06..91df62a 100644 --- a/src/pages/rules.tsx +++ b/src/pages/rules.tsx @@ -1,6 +1,6 @@ import { graphql } from "gatsby" import React, { Fragment } from "react" -import { MarkdownRemark, Query } from "../../generated/graphql" +import { MarkdownRemark } from "../../generated/graphql" import { Markdown } from "../components/Markdown" import { SEO } from "../components/SEO" diff --git a/tslint.json b/tslint.json index 2714450..5995b34 100644 --- a/tslint.json +++ b/tslint.json @@ -27,6 +27,7 @@ "no-eval": true, "no-parameter-reassignment": true, "no-submodule-imports": false, + "no-unused-variable": true, "react-hooks-nesting": "error" },