From 79e19c974fde244b6b3070899a7b744c929f53c2 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Sat, 14 Sep 2019 19:37:15 -0400 Subject: [PATCH 1/4] refact: add missing keys on mapped JSX --- src/components/ResourceBreadcrumb/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/ResourceBreadcrumb/index.tsx b/src/components/ResourceBreadcrumb/index.tsx index 5637a8f..ef2b67c 100644 --- a/src/components/ResourceBreadcrumb/index.tsx +++ b/src/components/ResourceBreadcrumb/index.tsx @@ -69,14 +69,14 @@ export function ResourceBreadcrumb({ relativePath }: IResourceBreadcrumbProps) { {breadcrumbItems.map(item => { if (item.type === "folder") { return ( - + ) } - return {item.title} + return {item.title} })} ) From d93382045441170717c46edfdc828dde5655c342 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Sat, 14 Sep 2019 19:51:34 -0400 Subject: [PATCH 2/4] style: auto-format code --- gatsby-browser.js | 2 +- src/SidebarProvider.tsx | 15 ++++++++------- src/components/Container/styles.tsx | 3 +-- src/components/Footer/index.tsx | 1 - src/components/ResourceHeader/styles.tsx | 2 +- src/components/ResourcesLayout/index.tsx | 4 +--- src/components/ResourcesSidebar/useBuildTree.tsx | 4 +++- 7 files changed, 15 insertions(+), 16 deletions(-) diff --git a/gatsby-browser.js b/gatsby-browser.js index b41f255..62e82aa 100644 --- a/gatsby-browser.js +++ b/gatsby-browser.js @@ -6,4 +6,4 @@ // You can delete this file if you're not using it -require('prismjs/themes/prism-tomorrow.css'); +require("prismjs/themes/prism-tomorrow.css") diff --git a/src/SidebarProvider.tsx b/src/SidebarProvider.tsx index d1dafb1..b70b137 100644 --- a/src/SidebarProvider.tsx +++ b/src/SidebarProvider.tsx @@ -13,15 +13,16 @@ export const SidebarContext = React.createContext ({ - current, - setCurrent, - }), [current, setCurrent]) + const memoizedContextValue = useMemo( + () => ({ + current, + setCurrent, + }), + [current, setCurrent] + ) return ( diff --git a/src/components/Container/styles.tsx b/src/components/Container/styles.tsx index af20a32..f98292c 100644 --- a/src/components/Container/styles.tsx +++ b/src/components/Container/styles.tsx @@ -1,4 +1,3 @@ import styled from "styled-components" -export const ContainerWrapper = styled.div` - ` +export const ContainerWrapper = styled.div`` diff --git a/src/components/Footer/index.tsx b/src/components/Footer/index.tsx index 1c7d38b..05b6aaa 100644 --- a/src/components/Footer/index.tsx +++ b/src/components/Footer/index.tsx @@ -11,7 +11,6 @@ export function Footer() { {` `} Gatsby

- ) diff --git a/src/components/ResourceHeader/styles.tsx b/src/components/ResourceHeader/styles.tsx index 7846bcf..b9ed884 100644 --- a/src/components/ResourceHeader/styles.tsx +++ b/src/components/ResourceHeader/styles.tsx @@ -1,7 +1,7 @@ import { Link } from "gatsby" +import { darken, lighten } from "polished" import styled, { css } from "styled-components" import { fontFamily, modularScale } from "../../design/typography" -import { darken, lighten } from "polished" export const ResourceHeaderWrapper = styled.div` border-bottom: 1px solid #dbdbdb; diff --git a/src/components/ResourcesLayout/index.tsx b/src/components/ResourcesLayout/index.tsx index 7d3d20b..a11acad 100644 --- a/src/components/ResourcesLayout/index.tsx +++ b/src/components/ResourcesLayout/index.tsx @@ -33,9 +33,7 @@ export function ResourcesLayout({ children }: PropsWithChildren<{}>) { - - {children} - + {children} obj.title === head.title && obj.type === head.type, From 120920c40c1de210dfb9db276e326ff0c6685379 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Sat, 14 Sep 2019 19:53:31 -0400 Subject: [PATCH 3/4] fix: resolve missing type imports --- src/pages/about.tsx | 1 + src/pages/rules.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/src/pages/about.tsx b/src/pages/about.tsx index 35b1d92..8305a92 100644 --- a/src/pages/about.tsx +++ b/src/pages/about.tsx @@ -1,6 +1,7 @@ import { graphql } from "gatsby" import React, { Fragment } from "react" import { MarkdownRemark } from "../../generated/graphql" +import { ComponentQuery } from "../../typings" import { Markdown } from "../components/Markdown" import { SEO } from "../components/SEO" diff --git a/src/pages/rules.tsx b/src/pages/rules.tsx index 91df62a..d1a802a 100644 --- a/src/pages/rules.tsx +++ b/src/pages/rules.tsx @@ -1,6 +1,7 @@ import { graphql } from "gatsby" import React, { Fragment } from "react" import { MarkdownRemark } from "../../generated/graphql" +import { ComponentQuery } from "../../typings" import { Markdown } from "../components/Markdown" import { SEO } from "../components/SEO" From 1078d7702b1c29e72aeb46c6ec3b7772fae39bc5 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Sirois Date: Sat, 14 Sep 2019 19:55:14 -0400 Subject: [PATCH 4/4] style: remove dead code --- src/components/ResourcesSidebar/styles.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/ResourcesSidebar/styles.tsx b/src/components/ResourcesSidebar/styles.tsx index 17305e5..7757d94 100644 --- a/src/components/ResourcesSidebar/styles.tsx +++ b/src/components/ResourcesSidebar/styles.tsx @@ -120,7 +120,6 @@ export const TreeWrapper = styled.div<{ collapsed: boolean }>` ${Children} { display: ${props => (props.collapsed ? "none" : "flex")}; - /* height: ${props => (props.collapsed ? 0 : "auto")}; */ } & > ${Label} svg {