Merge pull request #7 from RunninglVlan/patch-1

Added consistency in code formatting
This commit is contained in:
Konstantin
2018-11-09 19:26:05 +03:00
committed by GitHub
+184 -147
View File
@@ -1,7 +1,7 @@
# C# Coding Standards and Naming Conventions
| SQL Server Object Name | Notation | Length | Plural | Prefix | Suffix | Abbreviation | Char Mask |Underscores |
| SQL Server Object Name | Notation | Length | Plural | Prefix | Suffix | Abbreviation | Char Mask | Underscores |
|:--------------------------|:-----------|-------:|:-------|:-------|:-------|:-------------|:-------------------|:------------|
| Class name | PascalCase | 128 | No | No | Yes | No | [A-z][0-9] | No |
| Constructor name | PascalCase | 128 | No | No | Yes | No | [A-z][0-9] | No |
@@ -27,7 +27,7 @@ public class ClientActivity
{
//...
}
}
}
```
***Why: consistent with the Microsoft's .NET Framework and easy to read.***
@@ -35,44 +35,46 @@ public class ClientActivity
#### 2. Do use camelCasing for method arguments and local variables:
```csharp
public class UserLog
{
public class UserLog
{
public void Add(LogEvent logEvent)
{
int itemCount = logEvent.Items.Count;
// ...
}
}
}
}
```
***Why: consistent with the Microsoft's .NET Framework and easy to read.***
#### 3. Do not use Hungarian notation or any other type identification in identifiers
```csharp
// Correct
int counter;
string name;
// Avoid
int iCounter;
string strName;
// Correct
int counter;
string name;
// Avoid
int iCounter;
string strName;
```
***Why: consistent with the Microsoft's .NET Framework and Visual Studio IDE makes determining types very easy (via tooltips). In general you want to avoid type indicators in any identifier.***
#### 4. Do not use Screaming Caps for constants or readonly variables
#### 4. Do not use Screaming Caps for constants or readonly variables:
```csharp
// Correct
public static const string ShippingType = "DropShip";
// Avoid
public static const string SHIPPINGTYPE = "DropShip";
// Correct
public static const string ShippingType = "DropShip";
// Avoid
public static const string SHIPPINGTYPE = "DropShip";
```
***Why: consistent with the Microsoft's .NET Framework. Caps grap too much attention.***
#### 5. Use meaningful names for variables. The following example uses seattleCustomers for customers who are located in Seattle:
```csharp
var seattleCustomers = from cust in customers
var seattleCustomers = from cust in customers
where cust.City == "Seattle"
select cust.Name;
```
@@ -80,55 +82,59 @@ public class ClientActivity
***Why: consistent with the Microsoft's .NET Framework and easy to read.***
#### 6. Avoid using Abbreviations. Exceptions: abbreviations commonly used as names, such as Id, Xml, Ftp, Uri.
```csharp
// Correct
UserGroup userGroup;
Assignment employeeAssignment;
// Avoid
UserGroup usrGrp;
Assignment empAssignment;
// Exceptions
CustomerId customerId;
XmlDocument xmlDocument;
FtpHelper ftpHelper;
UriPart uriPart;
// Correct
UserGroup userGroup;
Assignment employeeAssignment;
// Avoid
UserGroup usrGrp;
Assignment empAssignment;
// Exceptions
CustomerId customerId;
XmlDocument xmlDocument;
FtpHelper ftpHelper;
UriPart uriPart;
```
***Why: consistent with the Microsoft's .NET Framework and prevents inconsistent abbreviations.***
#### 7. Do use PascalCasing for abbreviations 3 characters or more (2 chars are both uppercase)
#### 7. Do use PascalCasing for abbreviations 3 characters or more (2 chars are both uppercase):
```csharp
HtmlHelper htmlHelper;
FtpTransfer ftpTransfer;
UIControl uiControl;
HtmlHelper htmlHelper;
FtpTransfer ftpTransfer;
UIControl uiControl;
```
***Why: consistent with the Microsoft's .NET Framework. Caps would grap visually too much attention.***
#### 8. Do not use Underscores in identifiers. Exception: you can prefix private static variables with an underscore:
```csharp
// Correct
public DateTime clientAppointment;
public TimeSpan timeLeft;
// Avoid
public DateTime client_Appointment;
public TimeSpan time_Left;
// Exception (Class field)
private DateTime _registrationDate;
// Correct
public DateTime clientAppointment;
public TimeSpan timeLeft;
// Avoid
public DateTime client_Appointment;
public TimeSpan time_Left;
// Exception (Class field)
private DateTime _registrationDate;
```
***Why: consistent with the Microsoft's .NET Framework and makes code more natural to read (without 'slur'). Also avoids underline stress (inability to see underline).***
#### 9. Do use predefined type names instead of system type names like Int16, Single, UInt64, etc
#### 9. Do use predefined type names instead of system type names like Int16, Single, UInt64, etc.
```csharp
// Correct
string firstName;
int lastIndex;
bool isSaved;
// Avoid
String firstName;
Int32 lastIndex;
Boolean isSaved;
// Correct
string firstName;
int lastIndex;
bool isSaved;
// Avoid
String firstName;
Int32 lastIndex;
Boolean isSaved;
```
***Why: consistent with the Microsoft's .NET Framework and makes code more natural to read.***
@@ -136,12 +142,12 @@ public class ClientActivity
#### 10. Do use implicit type var for local variable declarations. Exception: primitive types (int, string, double, etc) use predefined names.
```csharp
var stream = File.Create(path);
var customers = new Dictionary();
// Exceptions
int index = 100;
string timeSheet;
bool isCompleted;
var stream = File.Create(path);
var customers = new Dictionary();
// Exceptions
int index = 100;
string timeSheet;
bool isCompleted;
```
***Why: removes clutter, particularly with complex generic types. Type is easily detected with Visual Studio tooltips.***
@@ -149,30 +155,31 @@ public class ClientActivity
#### 11. Do use noun or noun phrases to name a class.
```csharp
public class Employee
{
}
public class BusinessLocation
{
}
public class DocumentCollection
{
}
public class Employee
{
}
public class BusinessLocation
{
}
public class DocumentCollection
{
}
```
***Why: consistent with the Microsoft's .NET Framework and easy to remember.***
#### 12. Do prefix interfaces with the letter I. Interface names are noun (phrases) or adjectives.
```csharp
public interface IShape
{
}
public interface IShapeCollection
{
}
public interface IGroupable
{
}
public interface IShape
{
}
public interface IShapeCollection
{
}
public interface IGroupable
{
}
```
***Why: consistent with the Microsoft's .NET Framework.***
@@ -180,16 +187,14 @@ public class ClientActivity
#### 13. Do name source files according to their main classes. Exception: file names with partial classes reflect their source or purpose, e.g. designer, generated, etc.
```csharp
// Located in Task.cs
public partial class Task
{
//...
}
// Located in Task.generated.cs
public partial class Task
{
//...
}
// Located in Task.cs
public partial class Task
{
}
// Located in Task.generated.cs
public partial class Task
{
}
```
***Why: consistent with the Microsoft practices. Files are alphabetically sorted and partial classes remain adjacent.***
@@ -197,160 +202,188 @@ public class ClientActivity
#### 14. Do organize namespaces with a clearly defined structure:
```csharp
// Examples
namespace Company.Product.Module.SubModule
namespace Product.Module.Component
namespace Product.Layer.Module.Group
// Examples
namespace Company.Product.Module.SubModule
{
}
namespace Product.Module.Component
{
}
namespace Product.Layer.Module.Group
{
}
```
***Why: consistent with the Microsoft's .NET Framework. Maintains good organization of your code base.***
#### 15. Do vertically align curly brackets:
```csharp
// Correct
class Program
{
// Correct
class Program
{
static void Main(string[] args)
{
//...
}
}
}
```
***Why: Microsoft has a different standard, but developers have overwhelmingly preferred vertically aligned brackets.***
#### 16. Do declare all member variables at the top of a class, with static variables at the very top.
```csharp
// Correct
public class Account
{
// Correct
public class Account
{
public static string BankName;
public static decimal Reserves;
public string Number {get; set;}
public DateTime DateOpened {get; set;}
public DateTime DateClosed {get; set;}
public decimal Balance {get; set;}
public string Number { get; set; }
public DateTime DateOpened { get; set; }
public DateTime DateClosed { get; set; }
public decimal Balance { get; set; }
// Constructor
public Account()
{
// ...
}
}
}
```
***Why: generally accepted practice that prevents the need to hunt for variable declarations.***
#### 17. Do use singular names for enums. Exception: bit field enums.
```csharp
// Correct
public enum Color
{
// Correct
public enum Color
{
Red,
Green,
Blue,
Yellow,
Magenta,
Cyan
}
// Exception
[Flags]
public enum Dockings
{
}
// Exception
[Flags]
public enum Dockings
{
None = 0,
Top = 1,
Right = 2,
Bottom = 4,
Left = 8
}
}
```
***Why: consistent with the Microsoft's .NET Framework and makes the code more natural to read. Plural flags because enum can hold multiple values (using bitwise 'OR').***
#### 18. Do not explicitly specify a type of an enum or values of enums (except bit fields)
#### 18. Do not explicitly specify a type of an enum or values of enums (except bit fields):
```csharp
// Don't
public enum Direction : long
{
// Don't
public enum Direction : long
{
North = 1,
East = 2,
South = 3,
West = 4
}
// Correct
public enum Direction
{
}
// Correct
public enum Direction
{
North,
East,
South,
West
}
}
```
***Why: can create confusion when relying on actual types and values.***
#### 19. Do not use an "Enum" suffix in enum type names.
#### 19. Do not use an "Enum" suffix in enum type names:
```csharp
// Don't
public enum CoinEnum
{
// Don't
public enum CoinEnum
{
Penny,
Nickel,
Dime,
Quarter,
Dollar
}
// Correct
public enum Coin
{
}
// Correct
public enum Coin
{
Penny,
Nickel,
Dime,
Quarter,
Dollar
}
}
```
***Why: consistent with the Microsoft's .NET Framework and consistent with prior rule of no type indicators in identifiers.***
#### 20. Do not use "Flag" or Flags" suffixes in enum type names.
#### 20. Do not use "Flag" or "Flags" suffixes in enum type names:
```csharp
//Don't
[Flags]
public enum DockingsFlags
{
// Don't
[Flags]
public enum DockingsFlags
{
None = 0,
Top = 1,
Right = 2,
Bottom = 4,
Left = 8
}
//Correct
[Flags]
public enum Dockings
{
}
// Correct
[Flags]
public enum Dockings
{
None = 0,
Top = 1,
Right = 2,
Bottom = 4,
Left = 8
}
}
```
***Why: consistent with the Microsoft's .NET Framework and consistent with prior rule of no type indicators in identifiers.***
#### 21. Do use suffix EventArgs at creation of the new classes comprising the information on event:
```csharp
// Correct
public void BarcodeReadEventArgs : System.EventArgs
// Correct
public class BarcodeReadEventArgs : System.EventArgs
{
}
```
***Why: consistent with the Microsoft's .NET Framework and easy to read.***
#### 22. Do name event handlers (delegates used as types of events) with the "EventHandler" suffix, as shown in the following example:
```csharp
public delegate void ReadBarcodeEventHandler(object sender, ReadBarcodeEventArgs e);
public delegate void ReadBarcodeEventHandler(object sender, ReadBarcodeEventArgs e);
```
***Why: consistent with the Microsoft's .NET Framework and easy to read.***
#### 23. Do not create names of parametres in methods (or constructors) which differ only the register:
#### 23. Do not create names of parametres in methods (or constructors) which differ only by the register:
```csharp
// Avoid
private void MyFunction(string name, string Name)
// Avoid
private void MyFunction(string name, string Name)
{
//...
}
```
***Why: consistent with the Microsoft's .NET Framework and easy to read, and also excludes possibility of occurrence of conflict situations.***
#### 24. DO use two parameters named sender and e in event handlers. The sender parameter represents the object that raised the event. The sender parameter is typically of type object, even if it is possible to employ a more specific type.
@@ -360,10 +393,14 @@ public class ClientActivity
***Why: consistent with the Microsoft's .NET Framework and consistent with prior rule of no type indicators in identifiers.***
#### 25. Do use suffix Exception at creation of the new classes comprising the information on exception:
```csharp
// Correct
public void BarcodeReadException : System.Exception
// Correct
public class BarcodeReadException : System.Exception
{
}
```
***Why: consistent with the Microsoft's .NET Framework and easy to read.***
## Offical Reference