mirror of
https://github.com/Stone-Red-Code/dvc.git
synced 2026-11-02 07:18:25 +01:00
skshetry
e5eec59cb8
We don't have aiohttp support yet, due to which we have to install without cythonized extension. Similarly, there has been some changes in how dataclasses disallows some mutable arguments to be set as a class property, due to which `hydra.conf` fails to import in 3.11. See https://github.com/python/cpython/pull/29867. For now, I have patched the module and avoid importing as a pytest-plugin. dvc-hdfs/pyarrow is not there yet, we'll usually see a release 2-3 months after official reelase. dvc-hdfs is skipped in 3.11 in extras_requires. `--set-params` will return a nice error message if hydra cannot be imported in 3.11. I decided to only patch that in tests.
126 lines
3.4 KiB
Python
126 lines
3.4 KiB
Python
import pytest
|
|
|
|
from dvc.exceptions import InvalidArgumentError
|
|
|
|
|
|
@pytest.mark.parametrize("suffix", ["yaml", "toml", "json"])
|
|
@pytest.mark.parametrize(
|
|
"overrides, expected",
|
|
[
|
|
# Overriding
|
|
(["foo=baz"], {"foo": "baz", "goo": {"bag": 3.0}, "lorem": False}),
|
|
(["foo=baz", "goo=bar"], {"foo": "baz", "goo": "bar", "lorem": False}),
|
|
(
|
|
["foo.0=bar"],
|
|
{"foo": ["bar", {"baz": 2}], "goo": {"bag": 3.0}, "lorem": False},
|
|
),
|
|
(
|
|
["foo.1.baz=3"],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 3}],
|
|
"goo": {"bag": 3.0},
|
|
"lorem": False,
|
|
},
|
|
),
|
|
(
|
|
["goo.bag=4.0"],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 2}],
|
|
"goo": {"bag": 4.0},
|
|
"lorem": False,
|
|
},
|
|
),
|
|
(
|
|
["++goo={bag: 1, b: 2}"],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 2}],
|
|
"goo": {"bag": 1, "b": 2},
|
|
"lorem": False,
|
|
},
|
|
),
|
|
# 6129
|
|
(
|
|
["lorem="],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 2}],
|
|
"goo": {"bag": 3.0},
|
|
"lorem": "",
|
|
},
|
|
),
|
|
# 6129
|
|
(
|
|
["lorem=null"],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 2}],
|
|
"goo": {"bag": 3.0},
|
|
"lorem": None,
|
|
},
|
|
),
|
|
# 5868
|
|
(
|
|
["lorem=1992-11-20"],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 2}],
|
|
"goo": {"bag": 3.0},
|
|
"lorem": "1992-11-20",
|
|
},
|
|
),
|
|
# 5868
|
|
(
|
|
["lorem='1992-11-20'"],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 2}],
|
|
"goo": {"bag": 3.0},
|
|
"lorem": "1992-11-20",
|
|
},
|
|
),
|
|
# Appending
|
|
(
|
|
["+a=1"],
|
|
{
|
|
"foo": [{"bar": 1}, {"baz": 2}],
|
|
"goo": {"bag": 3.0},
|
|
"lorem": False,
|
|
"a": 1,
|
|
},
|
|
),
|
|
# Removing
|
|
(["~foo"], {"goo": {"bag": 3.0}, "lorem": False}),
|
|
],
|
|
)
|
|
def test_apply_overrides(tmp_dir, suffix, overrides, expected):
|
|
from dvc.utils.hydra import apply_overrides
|
|
|
|
if suffix == "toml":
|
|
if overrides in [
|
|
["foo=baz"],
|
|
["foo.0=bar"],
|
|
["foo=baz", "goo=bar"],
|
|
["lorem=null"],
|
|
]:
|
|
# TOML dumper breaks when overriding a list/dict with other type
|
|
# or when handling `null` values.
|
|
pytest.xfail()
|
|
|
|
params_file = tmp_dir / f"params.{suffix}"
|
|
params_file.dump(
|
|
{"foo": [{"bar": 1}, {"baz": 2}], "goo": {"bag": 3.0}, "lorem": False}
|
|
)
|
|
apply_overrides(path=params_file.name, overrides=overrides)
|
|
assert params_file.parse() == expected
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"overrides",
|
|
[["foobar=2"], ["lorem=3,2"], ["+lorem=3"], ["foo[0]=bar"]],
|
|
)
|
|
def test_invalid_overrides(tmp_dir, overrides):
|
|
from dvc.utils.hydra import apply_overrides
|
|
|
|
params_file = tmp_dir / "params.yaml"
|
|
params_file.dump(
|
|
{"foo": [{"bar": 1}, {"baz": 2}], "goo": {"bag": 3.0}, "lorem": False}
|
|
)
|
|
with pytest.raises(InvalidArgumentError):
|
|
apply_overrides(path=params_file.name, overrides=overrides)
|