mirror of
https://github.com/Stone-Red-Code/dvc.git
synced 2026-11-05 23:09:32 +01:00
c3a61ad9cf
* Added SSL verification option * Changed param name to avoid conflicts * verify_ssl now accepts strings * Added simple unit tests * Changed parameter name fron verify_ssl to ssl_verify so it's consistent with HTTP remotes Forget to change 1 test * add processing on ssl_verify param typo * revert back to bool param * Update dvc/config_schema.py Co-authored-by: Nigel <[email protected]> Co-authored-by: Nigel <[email protected]> Co-authored-by: Ruslan Kuprieiev <[email protected]>
131 lines
3.7 KiB
Python
131 lines
3.7 KiB
Python
import pytest
|
|
|
|
from dvc.config import ConfigError
|
|
from dvc.exceptions import DvcException
|
|
from dvc.fs.s3 import S3FileSystem
|
|
|
|
bucket_name = "bucket-name"
|
|
prefix = "some/prefix"
|
|
url = f"s3://{bucket_name}/{prefix}"
|
|
key_id = "key-id"
|
|
key_secret = "key-secret"
|
|
session_token = "session-token"
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def grants():
|
|
return {
|
|
"grant_read": "id=read-permission-id,id=other-read-permission-id",
|
|
"grant_read_acp": "id=read-acp-permission-id",
|
|
"grant_write_acp": "id=write-acp-permission-id",
|
|
"grant_full_control": "id=full-control-permission-id",
|
|
}
|
|
|
|
|
|
def test_init(dvc):
|
|
config = {"url": url}
|
|
fs = S3FileSystem(dvc, config)
|
|
|
|
assert fs.path_info == url
|
|
|
|
|
|
def test_verify_ssl_default_param(dvc):
|
|
config = {
|
|
"url": url,
|
|
}
|
|
fs = S3FileSystem(dvc, config)
|
|
|
|
assert fs.ssl_verify
|
|
|
|
|
|
def test_ssl_verify_bool_param(dvc):
|
|
config = {"url": url, "ssl_verify": False}
|
|
fs = S3FileSystem(dvc, config)
|
|
|
|
assert fs.ssl_verify == config["ssl_verify"]
|
|
|
|
|
|
def test_grants(dvc):
|
|
config = {
|
|
"url": url,
|
|
"grant_read": "id=read-permission-id,id=other-read-permission-id",
|
|
"grant_read_acp": "id=read-acp-permission-id",
|
|
"grant_write_acp": "id=write-acp-permission-id",
|
|
"grant_full_control": "id=full-control-permission-id",
|
|
}
|
|
fs = S3FileSystem(dvc, config)
|
|
|
|
assert (
|
|
fs.extra_args["GrantRead"]
|
|
== "id=read-permission-id,id=other-read-permission-id"
|
|
)
|
|
assert fs.extra_args["GrantReadACP"] == "id=read-acp-permission-id"
|
|
assert fs.extra_args["GrantWriteACP"] == "id=write-acp-permission-id"
|
|
assert fs.extra_args["GrantFullControl"] == "id=full-control-permission-id"
|
|
|
|
|
|
def test_grants_mutually_exclusive_acl_error(dvc, grants):
|
|
for grant_option, grant_value in grants.items():
|
|
config = {"url": url, "acl": "public-read", grant_option: grant_value}
|
|
|
|
with pytest.raises(ConfigError):
|
|
S3FileSystem(dvc, config)
|
|
|
|
|
|
def test_sse_kms_key_id(dvc):
|
|
fs = S3FileSystem(dvc, {"url": url, "sse_kms_key_id": "key"})
|
|
assert fs.extra_args["SSEKMSKeyId"] == "key"
|
|
|
|
|
|
def test_key_id_and_secret(dvc):
|
|
fs = S3FileSystem(
|
|
dvc,
|
|
{
|
|
"url": url,
|
|
"access_key_id": key_id,
|
|
"secret_access_key": key_secret,
|
|
"session_token": session_token,
|
|
},
|
|
)
|
|
assert fs.access_key_id == key_id
|
|
assert fs.secret_access_key == key_secret
|
|
assert fs.session_token == session_token
|
|
|
|
|
|
def test_get_s3_no_credentials(mocker):
|
|
from botocore.exceptions import NoCredentialsError
|
|
|
|
fs = S3FileSystem(None, {})
|
|
with pytest.raises(DvcException, match="Unable to find AWS credentials"):
|
|
with fs._get_s3():
|
|
raise NoCredentialsError
|
|
|
|
|
|
def test_get_s3_connection_error(mocker):
|
|
from botocore.exceptions import EndpointConnectionError
|
|
|
|
fs = S3FileSystem(None, {})
|
|
|
|
msg = "Unable to connect to 'AWS S3'."
|
|
with pytest.raises(DvcException, match=msg):
|
|
with fs._get_s3():
|
|
raise EndpointConnectionError(endpoint_url="url")
|
|
|
|
|
|
def test_get_s3_connection_error_endpoint(mocker):
|
|
from botocore.exceptions import EndpointConnectionError
|
|
|
|
fs = S3FileSystem(None, {"endpointurl": "https://example.com"})
|
|
|
|
msg = "Unable to connect to 'https://example.com'."
|
|
with pytest.raises(DvcException, match=msg):
|
|
with fs._get_s3():
|
|
raise EndpointConnectionError(endpoint_url="url")
|
|
|
|
|
|
def test_get_bucket():
|
|
fs = S3FileSystem(None, {"url": "s3://mybucket/path"})
|
|
with pytest.raises(DvcException, match="Bucket 'mybucket' does not exist"):
|
|
with fs._get_bucket("mybucket") as bucket:
|
|
raise bucket.meta.client.exceptions.NoSuchBucket({}, None)
|