mirror of
https://github.com/Stone-Red-Code/dvc.git
synced 2026-11-19 23:11:44 +01:00
As it turned out (see issue numbers down below), we can't really take hardlinks for granted, so `flufl.lock` is not a panacea for all filesystems. Considering that the vast majority of filesystems that our users use support `zc.lockfile`(flock-based) and it has benefits like more reliable mechanism, auto-delete when process exits, more sturdy implementation, etc, it makes more sense to bring it back and use by default again. For filesystems that don't support `flock()`, users will be able to manually enable `flufl.lock` use through the config option. It would be ideal if we could auto-detect that flock is not supported, but in the real world, it turned out to be non-trivial, as it might hang forever in a kernel context, which makes the implementation way too complex for our purposes. So what we're doing instead is showing a message before locking with `zc.lockfile` that, under normal circumstances will disappear once the lock is taken or failed, otherwise it will point users to the related documentation where they can learn about how to opt-in for `flufl.lock`. Fixes #2831 Fixes #2897 Related #2860
64 lines
1.6 KiB
Python
64 lines
1.6 KiB
Python
from __future__ import unicode_literals
|
|
|
|
import logging
|
|
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def fix_subparsers(subparsers):
|
|
"""Workaround for bug in Python 3. See more info at:
|
|
https://bugs.python.org/issue16308
|
|
https://github.com/iterative/dvc/issues/769
|
|
|
|
Args:
|
|
subparsers: subparsers to fix.
|
|
"""
|
|
from dvc.utils.compat import is_py3
|
|
|
|
if is_py3: # pragma: no cover
|
|
subparsers.required = True
|
|
subparsers.dest = "cmd"
|
|
|
|
|
|
def append_doc_link(help_message, path):
|
|
from dvc.utils import format_link
|
|
|
|
if not path:
|
|
return help_message
|
|
doc_base = "https://man.dvc.org/"
|
|
return "{message}\nDocumentation: {link}".format(
|
|
message=help_message, link=format_link(doc_base + path)
|
|
)
|
|
|
|
|
|
class CmdBase(object):
|
|
def __init__(self, args):
|
|
from dvc.repo import Repo
|
|
from dvc.updater import Updater
|
|
|
|
self.repo = Repo()
|
|
self.config = self.repo.config
|
|
self.args = args
|
|
hardlink_lock = self.config.config["core"].get("hardlink_lock", False)
|
|
updater = Updater(self.repo.dvc_dir, hardlink_lock=hardlink_lock)
|
|
updater.check()
|
|
|
|
@property
|
|
def default_targets(self):
|
|
"""Default targets for `dvc repro` and `dvc pipeline`."""
|
|
from dvc.stage import Stage
|
|
|
|
msg = "assuming default target '{}'.".format(Stage.STAGE_FILE)
|
|
logger.warning(msg)
|
|
return [Stage.STAGE_FILE]
|
|
|
|
# Abstract methods that have to be implemented by any inheritance class
|
|
def run(self):
|
|
raise NotImplementedError
|
|
|
|
|
|
class CmdBaseNoRepo(CmdBase):
|
|
def __init__(self, args):
|
|
self.args = args
|