mirror of
https://github.com/Stone-Red-Code/dvc.git
synced 2026-11-02 07:18:25 +01:00
Christoph BerganskiandChristoph Berganski
2f48bb4089
* tree,remote: add support for webdav Webdav support is based on https://pypi.org/project/webdavclient3/ and supports basic download/upload operation, directory creation as well as existence, file hash and isdir query. Copy, move and remove are also implemented, though probably not used yet. WebdavURLInfo is taken from https://github.com/shizacat/dvc/tree/remote-webdav Fixes iterative#1153 * tree,remote: add further webdavclient3 options Webdav token auth, certificate and key path and connection timeout are configurable. Webdav username might be specified or extracted from URL. Refs iterative#1153 * tree,remote: validate webdav client configuration Refs iterative#1153 * tree,remote: WebDAV is written with capitalized 'DAV'... Refs iterative#1153 * tree,remote: terminate WebDAV makedirs at self.path_info.path This enables the WebDAV api location (e.g. '/public.php/webdav') to be part of the remote 'url' configuration instead of beeing specified separately via the 'root' option. The 'root' option may then be used to specify real directories at the WebDAV storage, although using it to set the api location is still possible. Refs iterative#1153 * tree,remote: use >=3.14.5 for WebDAV dependency webdavclient3 Context: https://github.com/iterative/dvc/pull/4256#discussion_r458490609 Refs iterative#1153 * tree,remote: get rid of WebDAV 'root' option and add connection check The WebDAV 'root' option was rather confusing and should be handled by the initial 'path_info' from the config 'url' option. Context: https://github.com/iterative/dvc/pull/4256#discussion_r458754500 While stripping the path/root from the hostname the port got lost, which is fixed now by simply using the URLInfo 'replace' method as suggested. Context: https://github.com/iterative/dvc/pull/4256#discussion_r458842853 The WebDAV client connection is tested by probing the existence of the root (self.path_info.path). Refs iterative#1153 * tree,remote: implement walk_files for WebDAV Context: https://github.com/iterative/dvc/pull/4256#discussion_r458751391 Refs: iterative#1153 * tree,remote: let WebDAV client list query file info in walk_files Context: https://github.com/iterative/dvc/pull/4256#discussion_r458751391 Refs iterative#1153 * tree,remote: add some unit tests for WebDAVTree Refs iterative#1153 * tree,remote: use ConfigError for WebDAVTree and move Error to webdav.py Context: https://github.com/iterative/dvc/pull/4256#discussion_r460591937 Refs iterative#1153 * tree,remote: remove/change some (unnecessary) comments Context: https://github.com/iterative/dvc/pull/4256#discussion_r460592181 * tree,remote: uploading to WebDAV only create directories if not exist * tree,remote: add BaseTree parameter use_dvcignore to WebDAVTree exists Refs iterative/#1153 * tree,remote: remove WebDAVTree copy method as proposed Context: https://github.com/iterative/dvc/pull/4256#discussion_r460892725 Refs iterative#1153 * tree,remote: add progress bar to WebDAV _download and _upload method Context: https://github.com/iterative/dvc/pull/4256#discussion_r460593130 Refs iterative#1153 Co-authored-by: Christoph Berganski <[email protected]>