mirror of
https://github.com/Stone-Red-Code/dvc.git
synced 2026-11-10 15:28:34 +01:00
Ruslan Kuprieiev
803ffaec57
Imagine the scenario of shared cache. To set it up, user would do: ``` dvc config cache.dir /path dvc config cache.shared group ``` Now, when he runs any dvc operation that involves the Repo instance, RemoteLOCAL will also be initialized and it will currently auto-create the directory with a regular `os.mkdir`, which is not using group permissions. To solve that, we can't simply use `self.makdirs` instead, as it will cause same issues if you run any dvc command before `dvc config cache.shared group`. So what we should do is create directories on demand, instead of creating it in advance, same as we do in other remotes. The change itself is pretty trivial and involved removing that `mkdir` line, adjusting tests to not rely on cache dir existence and also adjusting `dvc version` to not rely on cache directory existance. Fixes #2563
139 lines
4.1 KiB
Python
139 lines
4.1 KiB
Python
from __future__ import unicode_literals
|
|
|
|
import os
|
|
import platform
|
|
import argparse
|
|
import logging
|
|
import uuid
|
|
import itertools
|
|
|
|
try:
|
|
import psutil
|
|
except ImportError:
|
|
psutil = None
|
|
|
|
from dvc.utils import is_binary
|
|
from dvc.utils.compat import pathlib
|
|
from dvc.command.base import CmdBaseNoRepo, append_doc_link
|
|
from dvc.version import __version__
|
|
from dvc.exceptions import DvcException, NotDvcRepoError
|
|
from dvc.system import System
|
|
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class CmdVersion(CmdBaseNoRepo):
|
|
def run(self):
|
|
from dvc.repo import Repo
|
|
|
|
dvc_version = __version__
|
|
python_version = platform.python_version()
|
|
platform_type = platform.platform()
|
|
binary = is_binary()
|
|
|
|
info = (
|
|
"DVC version: {dvc_version}\n"
|
|
"Python version: {python_version}\n"
|
|
"Platform: {platform_type}\n"
|
|
"Binary: {binary}\n"
|
|
).format(
|
|
dvc_version=dvc_version,
|
|
python_version=python_version,
|
|
platform_type=platform_type,
|
|
binary=binary,
|
|
)
|
|
|
|
try:
|
|
repo = Repo()
|
|
root_directory = repo.root_dir
|
|
|
|
# cache_dir might not exist yet (e.g. after `dvc init`), and we
|
|
# can't auto-create it, as it might cause issues if the user
|
|
# later decides to enable shared cache mode with
|
|
# `dvc config cache.shared group`.
|
|
if os.path.exists(repo.cache.local.cache_dir):
|
|
info += "Cache: {cache}\n".format(
|
|
cache=self.get_linktype_support_info(repo)
|
|
)
|
|
else:
|
|
logger.warning(
|
|
"Unable to detect supported link types, as cache "
|
|
"directory '{}' doesn't exist. It is usually auto-created "
|
|
"by commands such as `dvc add/fetch/pull/run/import`, but "
|
|
"you could create it manually to enable this check."
|
|
)
|
|
|
|
if psutil:
|
|
info += (
|
|
"Filesystem type (cache directory): {fs_cache}\n"
|
|
).format(fs_cache=self.get_fs_type(repo.cache.local.cache_dir))
|
|
except NotDvcRepoError:
|
|
root_directory = os.getcwd()
|
|
|
|
if psutil:
|
|
info += ("Filesystem type (workspace): {fs_root}").format(
|
|
fs_root=self.get_fs_type(os.path.abspath(root_directory))
|
|
)
|
|
|
|
logger.info(info)
|
|
return 0
|
|
|
|
@staticmethod
|
|
def get_fs_type(path):
|
|
partition = {
|
|
pathlib.Path(part.mountpoint): (part.fstype, part.device)
|
|
for part in psutil.disk_partitions(all=True)
|
|
}
|
|
|
|
path = pathlib.Path(path)
|
|
|
|
for parent in itertools.chain([path], path.parents):
|
|
if parent in partition:
|
|
return partition[parent]
|
|
return ("unkown", "none")
|
|
|
|
@staticmethod
|
|
def get_linktype_support_info(repo):
|
|
links = {
|
|
"reflink": System.reflink,
|
|
"hardlink": System.hardlink,
|
|
"symlink": System.symlink,
|
|
}
|
|
|
|
fname = "." + str(uuid.uuid4())
|
|
src = os.path.join(repo.cache.local.cache_dir, fname)
|
|
open(src, "w").close()
|
|
dst = os.path.join(repo.root_dir, fname)
|
|
|
|
cache = []
|
|
|
|
for name, link in links.items():
|
|
try:
|
|
link(src, dst)
|
|
os.unlink(dst)
|
|
supported = True
|
|
except DvcException:
|
|
supported = False
|
|
cache.append(
|
|
"{name} - {supported}".format(
|
|
name=name, supported=True if supported else False
|
|
)
|
|
)
|
|
os.remove(src)
|
|
|
|
return ", ".join(cache)
|
|
|
|
|
|
def add_parser(subparsers, parent_parser):
|
|
VERSION_HELP = "Show DVC version and system/environment information."
|
|
|
|
version_parser = subparsers.add_parser(
|
|
"version",
|
|
parents=[parent_parser],
|
|
description=append_doc_link(VERSION_HELP, "version"),
|
|
help=VERSION_HELP,
|
|
formatter_class=argparse.RawDescriptionHelpFormatter,
|
|
)
|
|
version_parser.set_defaults(func=CmdVersion)
|