From fd65f44b7fe794720bd1b265539c827e3b296a39 Mon Sep 17 00:00:00 2001 From: Alexander Schepanovski Date: Tue, 2 Jun 2020 20:56:49 +0700 Subject: [PATCH] Fix quadratic behavior in Repo._collect_stages() (#3932) --- dvc/repo/__init__.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/dvc/repo/__init__.py b/dvc/repo/__init__.py index 947e492fc..dce018778 100644 --- a/dvc/repo/__init__.py +++ b/dvc/repo/__init__.py @@ -527,14 +527,13 @@ class Repo: for root, dirs, files in self.tree.walk(self.root_dir): for file_name in filter(is_valid_filename, files): - path = os.path.join(root, file_name) - stages.extend(self.get_stages(path)) + new_stages = self.get_stages(os.path.join(root, file_name)) + stages.extend(new_stages) outs.update( out.fspath - for stage in stages - for out in ( - out for out in stage.outs if out.scheme == "local" - ) + for stage in new_stages + for out in stage.outs + if out.scheme == "local" ) dirs[:] = [d for d in dirs if os.path.join(root, d) not in outs] return stages