From fd3b43df05ffbfb02e9a2ea47d7e8c1c3ac0c6fb Mon Sep 17 00:00:00 2001
From: skshetry <18718008+skshetry@users.noreply.github.com>
Date: Wed, 14 Aug 2024 16:55:18 +0545
Subject: [PATCH] fix test_daemon.py::test_analytics flakiness (#10523)

Turns out `iterative-telemetry` spends a long time trying to
generate an id. Sometimes it gets frozen for a long time (>30s).
---
 tests/func/test_daemon.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/func/test_daemon.py b/tests/func/test_daemon.py
index 8255bc1fd..bef6fcec7 100644
--- a/tests/func/test_daemon.py
+++ b/tests/func/test_daemon.py
@@ -97,6 +97,11 @@ def test_analytics(tmp_path, server):
     }
     env.pop("DVC_TEST", None)
     env.pop("DVC_NO_ANALYTICS", None)
+    # The `iterative-telemetry` package calls `gh api` to generate a CI id.
+    # This might hang especially on Windows,
+    # possibly due to system load from the running tests.
+    # Removing the GITHUB_ACTIONS env var avoids calling `gh api`.
+    env.pop("GITHUB_ACTIONS", None)
 
     output = subprocess.check_output(
         [*_get_dvc_args(), "config", "-l", "-vv"],
@@ -113,7 +118,7 @@ def test_analytics(tmp_path, server):
     pid = int(match.group(1).strip())
 
     with suppress(psutil.NoSuchProcess):
-        psutil.Process(pid).wait(timeout=30)
+        psutil.Process(pid).wait(timeout=10)
 
     log_contents = logfile.read_text(encoding="utf8")
     expected_line = (f"Process {pid} " if os.name != "nt" else "") + "exiting with 0"