Stone_Red/dvc
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/dvc.git synced 2026-11-10 23:10:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

dvc: show "Having any troubles?" only on unexpected errors (#4496)

Browse Source 
* dvc: dont catch generic exceptions

* dvc: show "Having any troubles?" only on unexpected errors

Fixes #4126
This commit is contained in:
Ruslan Kuprieiev
2020-08-30 21:08:12 +03:00
committed by GitHub
parent 1a35128457
commit fcbbfac7f8
5 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/func/test_check_ignore.py
+1 -1
View File
@@ -63,7 +63,7 @@ def test_check_ignore_non_matching(tmp_dir, dvc, non_matching, caplog):
)
def test_check_ignore_error_args_cases(tmp_dir, dvc, args, caplog):
assert main(["check-ignore"] + args) == 255
assert ("Having any troubles?" in caplog.text) == ("-q" not in args)
assert "Having any troubles?" not in caplog.text
@pytest.mark.parametrize("path,ret", [({"dir": {}}, 0), ({"dir": "files"}, 1)])