From f41dcea248277b8ede99d6d30df33ad5b4b2cf28 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Thu, 6 Jun 2019 13:44:13 +0300 Subject: [PATCH] tests: don't use var before assignment ``` repo_dir = git = @pytest.fixture def dvc_repo(repo_dir, git): try: dvc = DvcRepo.init(repo_dir._root_dir) dvc.scm.commit("init dvc") yield dvc finally: > dvc.scm.git.close() E UnboundLocalError: local variable 'dvc' referenced before assignment /home/efiop/git/dvc/tests/conftest.py:76: UnboundLocalError ``` --- tests/conftest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/conftest.py b/tests/conftest.py index 9de032b64..7e7d1208e 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -68,12 +68,14 @@ def git(repo_dir): @pytest.fixture def dvc_repo(repo_dir, git): + dvc = None try: dvc = DvcRepo.init(repo_dir._root_dir) dvc.scm.commit("init dvc") yield dvc finally: - dvc.scm.git.close() + if dvc: + dvc.scm.git.close() here = os.path.abspath(os.path.dirname(__file__))