From f10dbef0cfb5ada769f4b09d8275bfad3b1c1e6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Saugat=20Pachhai=20=28=E0=A4=B8=E0=A5=8C=E0=A4=97=E0=A4=BE?= =?UTF-8?q?=E0=A4=A4=29?= Date: Tue, 10 May 2022 14:14:31 +0545 Subject: [PATCH] TqdmCallback: minor fixup, check for None explicitly Tqdm supports __bool__, so we should really use `is not None` test rather than boolean check. This is not used anywhere right now, but I'd prefer being correct. --- dvc/fs/_callback.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dvc/fs/_callback.py b/dvc/fs/_callback.py index 87e9101b4..d08990ce2 100644 --- a/dvc/fs/_callback.py +++ b/dvc/fs/_callback.py @@ -108,7 +108,9 @@ class TqdmCallback(FsspecCallback): from dvc.progress import Tqdm return self._stack.enter_context( - self._progress_bar or Tqdm(**self._tqdm_kwargs) + self._progress_bar + if self._progress_bar is not None + else Tqdm(**self._tqdm_kwargs) ) def __enter__(self):