From eb8e03a465156cb3f2624fed8367b9e33b9594c5 Mon Sep 17 00:00:00 2001 From: Dmitry Kropachev <40304587+dkropachev@users.noreply.github.com> Date: Fri, 25 Dec 2020 10:56:04 +0700 Subject: [PATCH] dvc/tree/local: fix it for no repo/cache case (#5118) * dvc/tree/local: fix it for no repo/cache case fixes #5069 * Update dvc/output/base.py * Update dvc/output/base.py Co-authored-by: Ruslan Kuprieiev --- dvc/repo/get_url.py | 1 - tests/func/test_get_url.py | 10 ++++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/dvc/repo/get_url.py b/dvc/repo/get_url.py index d5569abbe..acf46d648 100644 --- a/dvc/repo/get_url.py +++ b/dvc/repo/get_url.py @@ -18,4 +18,3 @@ def get_url(url, out=None): if not dep.exists: raise dep.DoesNotExistError(dep) dep.download(out) - out.save() diff --git a/tests/func/test_get_url.py b/tests/func/test_get_url.py index 4d9969162..deb4c21b9 100644 --- a/tests/func/test_get_url.py +++ b/tests/func/test_get_url.py @@ -13,6 +13,16 @@ def test_get_file(tmp_dir): assert (tmp_dir / "foo_imported").read_text() == "foo contents" +def test_get_dir(tmp_dir): + tmp_dir.gen({"foo": {"foo": "foo contents"}}) + + Repo.get_url("foo", "foo_imported") + + assert (tmp_dir / "foo_imported").is_dir() + assert (tmp_dir / "foo_imported" / "foo").is_file() + assert (tmp_dir / "foo_imported" / "foo").read_text() == "foo contents" + + @pytest.mark.parametrize("dname", [".", "dir", "dir/subdir"]) def test_get_url_to_dir(tmp_dir, dname): tmp_dir.gen({"foo": "foo contents", "dir": {"subdir": {}}})