Stone_Red/dvc
1
0
Fork 0
mirror of https://github.com/Stone-Red-Code/dvc.git synced 2026-11-02 07:18:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

render: vega_converter: make rev and filename optional.

Browse Source 
Add `FILENAME_FIELD`.
This commit is contained in:
David de la Iglesia Castro
2022-03-28 19:34:05 +02:00
parent ddd6c97f71
commit ead7724824
9 changed files with 29 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/render/test_image_converter.py
+2 -2
View File
@@ -6,7 +6,7 @@ def test_image_converter_no_out():
data = b"content"
converter = ImageConverter()
datapoints, _ = converter.convert("r", "image.png", data)
datapoints, _ = converter.convert(data, "r", "image.png")
assert datapoints[0] == {
REVISION_FIELD: "r",
@@ -19,7 +19,7 @@ def test_image_converter_with_out(tmp_dir):
data = b"content"
converter = ImageConverter({"out": tmp_dir / "foo"})
datapoints, _ = converter.convert("r", "image.png", data)
datapoints, _ = converter.convert(data, "r", "image.png")
assert datapoints[0] == {
REVISION_FIELD: "r",
tests/unit/render/test_vega_converter.py
+2 -2
View File
@@ -132,7 +132,7 @@ def test_convert(
):
converter = VegaConverter(properties)
datapoints, resolved_properties = converter.convert(
revision="r", filename="f", data=input_data
data=input_data, revision="r", filename="f"
)
assert datapoints == expected_datapoints
@@ -144,9 +144,9 @@ def test_convert_skip_step():
converter.skip_step("append_index")
datapoints, resolved_properties = converter.convert(
data={"a": "b", "metric": [{"v": 1}, {"v": 2}]},
revision="r",
filename="f",
data={"a": "b", "metric": [{"v": 1}, {"v": 2}]},
)
assert datapoints == [