diff --git a/dvc/progress.py b/dvc/progress.py index b25f07d43..31c882f52 100644 --- a/dvc/progress.py +++ b/dvc/progress.py @@ -111,7 +111,7 @@ class Progress(object): logger = logging.getLogger(__name__) - if logger.getEffectiveLevel() == "CRITICAL": + if logger.getEffectiveLevel() == logging.CRITICAL: return print(*args, **kwargs) diff --git a/tests/unit/test_progress.py b/tests/unit/test_progress.py index 8bcee4167..e617c1775 100644 --- a/tests/unit/test_progress.py +++ b/tests/unit/test_progress.py @@ -1,14 +1,19 @@ +import logging import mock -from unittest import TestCase - -from dvc.progress import ProgressCallback +from dvc.progress import progress, ProgressCallback -class TestProgressCallback(TestCase): +def test_quiet(caplog, capsys): + with caplog.at_level(logging.CRITICAL, logger="dvc"): + progress._print("something") + assert capsys.readouterr().out == "" + + +class TestProgressCallback: @mock.patch("dvc.progress.progress") def test_should_init_reset_progress(self, progress_mock): total_files_num = 1 ProgressCallback(total_files_num) - self.assertEqual([mock.call.reset()], progress_mock.method_calls) + assert [mock.call.reset()] == progress_mock.method_calls