From c8958d737f0447ac99cab3ef3bf33fea5f2af763 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Mon, 23 Jul 2018 14:32:05 +0300 Subject: [PATCH 1/2] updater: set get() timeout Fixes #937 Signed-off-by: Ruslan Kuprieiev --- dvc/updater.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dvc/updater.py b/dvc/updater.py index 44f94ce8f..ab60e0bd4 100644 --- a/dvc/updater.py +++ b/dvc/updater.py @@ -9,6 +9,7 @@ class Updater(object): URL = 'https://4ki8820rsf.execute-api.us-east-2.amazonaws.com/prod/latest-version' UPDATER_FILE = 'updater' TIMEOUT = 7 * 24 * 60 * 60 #every week + TIMEOUT_GET = 10 def __init__(self, dvc_dir): self.dvc_dir = dvc_dir @@ -34,7 +35,7 @@ class Updater(object): os.unlink(self.updater_file) try: - r = requests.get(self.URL) + r = requests.get(self.URL, timeout=self.TIMEOUT_GET) j = r.json() latest = j['version'] open(self.updater_file, 'w+').close() From 7c2ef0c49cda436d9c1a6e51b74063740c7955d2 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Mon, 23 Jul 2018 14:34:54 +0300 Subject: [PATCH 2/2] updater: print "Checking for updates..." Fixes #935 Signed-off-by: Ruslan Kuprieiev --- dvc/updater.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dvc/updater.py b/dvc/updater.py index ab60e0bd4..10f859d7e 100644 --- a/dvc/updater.py +++ b/dvc/updater.py @@ -34,6 +34,8 @@ class Updater(object): os.unlink(self.updater_file) + Logger.info('Checking for updates...') + try: r = requests.get(self.URL, timeout=self.TIMEOUT_GET) j = r.json()