From d4ef461fceefed9fc503f59422a5b49cbb587f23 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Sat, 11 May 2019 16:56:32 +0300 Subject: [PATCH] version: use CmdBaseNoRepo Currently `dvc version` outside of dvc repo raises "not dvc repo" error, even though it is not really using repo in any way. Signed-off-by: Ruslan Kuprieiev --- dvc/command/version.py | 4 ++-- tests/unit/command/test_version.py | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/dvc/command/version.py b/dvc/command/version.py index 53b652c10..7b17c8f53 100644 --- a/dvc/command/version.py +++ b/dvc/command/version.py @@ -4,14 +4,14 @@ import platform import argparse import logging -from dvc.command.base import CmdBase, append_doc_link +from dvc.command.base import CmdBaseNoRepo, append_doc_link from dvc.version import __version__ logger = logging.getLogger(__name__) -class CmdVersion(CmdBase): +class CmdVersion(CmdBaseNoRepo): def run(self): info = ( "DVC version: {dvc_version}\n" diff --git a/tests/unit/command/test_version.py b/tests/unit/command/test_version.py index 42adda4c8..a36f06f27 100644 --- a/tests/unit/command/test_version.py +++ b/tests/unit/command/test_version.py @@ -4,7 +4,13 @@ from dvc.command.version import CmdVersion from dvc.cli import parse_args -def test_run(): +def test_run_in_repo(repo_dir, dvc): + cmd = CmdVersion(parse_args(["version"])) + ret = cmd.run_cmd() + assert ret == 0 + + +def test_run_outside_of_repo(repo_dir): cmd = CmdVersion(parse_args(["version"])) ret = cmd.run_cmd() assert ret == 0