From d4607d80501437b227e7c175b59678642268304b Mon Sep 17 00:00:00 2001 From: Ivan Shcheklein Date: Tue, 25 Jun 2019 21:02:33 -0700 Subject: [PATCH] fix s3 credential handling: DVC config overrides environment --- dvc/remote/s3.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/dvc/remote/s3.py b/dvc/remote/s3.py index 1e27841f8..0622ad2eb 100644 --- a/dvc/remote/s3.py +++ b/dvc/remote/s3.py @@ -50,13 +50,9 @@ class RemoteS3(RemoteBASE): url = config.get(Config.SECTION_REMOTE_URL, storagepath) self.path_info = self.path_cls(url) - self.region = os.environ.get("AWS_DEFAULT_REGION") or config.get( - Config.SECTION_AWS_REGION - ) + self.region = config.get(Config.SECTION_AWS_REGION) - self.profile = os.environ.get("AWS_PROFILE") or config.get( - Config.SECTION_AWS_PROFILE - ) + self.profile = config.get(Config.SECTION_AWS_PROFILE) self.endpoint_url = config.get(Config.SECTION_AWS_ENDPOINT_URL)