From c6050efbe3ebde6d07ceb8c762df586ba7f1f670 Mon Sep 17 00:00:00 2001 From: Mayur Kularni Date: Sun, 8 Dec 2019 14:35:51 +0530 Subject: [PATCH] codeclimate recommendation fix --- dvc/external_repo.py | 6 ++---- tests/func/test_external_repo.py | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/dvc/external_repo.py b/dvc/external_repo.py index e4f6586b1..abe4c6d04 100644 --- a/dvc/external_repo.py +++ b/dvc/external_repo.py @@ -4,12 +4,10 @@ import os import tempfile from contextlib import contextmanager from distutils.dir_util import copy_tree - -from dvc.remote import RemoteConfig from funcy import retry - from dvc.exceptions import NoRemoteInExternalRepoError +from dvc.remote import RemoteConfig from dvc.config import NoRemoteError, ConfigError from dvc.exceptions import NoOutputInExternalRepoError from dvc.exceptions import OutputNotFoundError @@ -145,4 +143,4 @@ def _remote_config_exists(rconfig): default = rconfig.get_default() except ConfigError: default = None - return True if default else False + return bool(default) diff --git a/tests/func/test_external_repo.py b/tests/func/test_external_repo.py index d21e056a9..e6a8ee7bc 100644 --- a/tests/func/test_external_repo.py +++ b/tests/func/test_external_repo.py @@ -1,8 +1,8 @@ import os -from dvc.repo import Repo from mock import patch +from dvc.repo import Repo from dvc.external_repo import external_repo from dvc.scm.git import Git from dvc.utils.fs import path_isin