From be824ede0d68df09af181e87039f8a3bed1cce76 Mon Sep 17 00:00:00 2001 From: skshetry <18718008+skshetry@users.noreply.github.com> Date: Wed, 15 Feb 2023 16:25:45 +0545 Subject: [PATCH] render: avoid deepcopying (#9033) * render: avoid deepcopying * remove unnecessary line --- dvc/render/convert.py | 4 +--- dvc/render/converter/vega.py | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/dvc/render/convert.py b/dvc/render/convert.py index dec94b5cd..828f5383b 100644 --- a/dvc/render/convert.py +++ b/dvc/render/convert.py @@ -29,10 +29,8 @@ def _group_by_rev(datapoints): def to_json(renderer, split: bool = False) -> List[Dict]: - from copy import deepcopy - if renderer.TYPE == "vega": - grouped = _group_by_rev(deepcopy(renderer.datapoints)) + grouped = _group_by_rev(renderer.datapoints) if split: content = renderer.get_filled_template(skip_anchors=["data"]) else: diff --git a/dvc/render/converter/vega.py b/dvc/render/converter/vega.py index 705e0ecae..258a06aec 100644 --- a/dvc/render/converter/vega.py +++ b/dvc/render/converter/vega.py @@ -1,4 +1,3 @@ -from copy import deepcopy from typing import Any, Dict, Iterable, List, Optional, Tuple, Union from funcy import first, last @@ -233,7 +232,7 @@ class VegaConverter(Converter): for i, (y_file, y_field) in enumerate(ys): if num_xs > 1: x_file, x_field = xs[i] - datapoints = deepcopy(file2datapoints.get(y_file, [])) + datapoints = [d.copy() for d in file2datapoints.get(y_file, [])] if props_update.get("y", None) == "dvc_inferred_y_value": _update_from_field(