From b2fc194e2ba50f20c159a1bac2fc1f38e5da2fbe Mon Sep 17 00:00:00 2001 From: skshetry <18718008+skshetry@users.noreply.github.com> Date: Fri, 10 Nov 2023 15:54:08 +0545 Subject: [PATCH] fix name of the loggers used (#10085) __name__ looks something like `dvc.commands.diff`, but if we are already instantiating root logger with `dvc`, it adds up to create something like `dvc.dvc.commands.diff`. We should be using a root logger here instead. --- dvc/cli/__init__.py | 3 +++ dvc/log.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dvc/cli/__init__.py b/dvc/cli/__init__.py index 070cafcb6..ffff0eb85 100644 --- a/dvc/cli/__init__.py +++ b/dvc/cli/__init__.py @@ -12,6 +12,9 @@ from dvc.log import logger "".encode("idna") +logger = logger.getChild(__name__) + + class DvcParserError(Exception): """Base class for CLI parser errors.""" diff --git a/dvc/log.py b/dvc/log.py index 5d48b1ed3..41c026dc9 100644 --- a/dvc/log.py +++ b/dvc/log.py @@ -7,4 +7,4 @@ class LoggerWithTrace(logging.Logger): trace = logging.debug -logger: "LoggerWithTrace" = logging.getLogger("dvc") # type: ignore[assignment] +logger: "LoggerWithTrace" = logging.getLogger() # type: ignore[assignment]