From a8b7fda5a2396aa451c1f2a4d226ae9d152a3715 Mon Sep 17 00:00:00 2001 From: Batuhan Taskaya Date: Mon, 19 Apr 2021 17:25:45 +0300 Subject: [PATCH] metrics: pass --precision to _show_metrics (#5839) * metrics: pass --precision to _show_metrics * tests: return empty string --- dvc/command/metrics.py | 1 + tests/unit/command/test_metrics.py | 19 +++++++++++++++++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/dvc/command/metrics.py b/dvc/command/metrics.py index 379ebe295..f8d01eae6 100644 --- a/dvc/command/metrics.py +++ b/dvc/command/metrics.py @@ -95,6 +95,7 @@ class CmdMetricsShow(CmdMetricsBase): self.args.all_branches, self.args.all_tags, self.args.all_commits, + self.args.precision, ) if table: logger.info(table) diff --git a/tests/unit/command/test_metrics.py b/tests/unit/command/test_metrics.py index 8abd9ab59..cdfa6fbf8 100644 --- a/tests/unit/command/test_metrics.py +++ b/tests/unit/command/test_metrics.py @@ -111,16 +111,23 @@ def test_metrics_show(dvc, mocker): "--all-commits", "target1", "target2", + "--precision", + "8", ] ) assert cli_args.func == CmdMetricsShow cmd = cli_args.func(cli_args) - m = mocker.patch("dvc.repo.metrics.show.show", return_value={}) + m1 = mocker.patch("dvc.repo.metrics.show.show", return_value={}) + m2 = mocker.patch( + "dvc.command.metrics._show_metrics", + spec=_show_metrics, + return_value="", + ) assert cmd.run() == 0 - m.assert_called_once_with( + m1.assert_called_once_with( cmd.repo, ["target1", "target2"], recursive=True, @@ -128,6 +135,14 @@ def test_metrics_show(dvc, mocker): all_branches=True, all_commits=True, ) + m2.assert_called_once_with( + {}, + markdown=False, + all_tags=True, + all_branches=True, + all_commits=True, + precision=8, + ) def test_metrics_diff_precision():