From 9bd9ac4a3749364d3aadae22e341fd048e9d809f Mon Sep 17 00:00:00 2001 From: David de la Iglesia Castro Date: Wed, 4 May 2022 09:35:25 +0200 Subject: [PATCH] FileSystem: Handle `encoding` via `kwargs`. Drop if None. Closes #7691 --- dvc/fs/base.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dvc/fs/base.py b/dvc/fs/base.py index 818b350df..edea3c8bd 100644 --- a/dvc/fs/base.py +++ b/dvc/fs/base.py @@ -180,10 +180,11 @@ class FileSystem: self, path: AnyFSPath, mode: str = "r", - encoding: Optional[str] = None, **kwargs, ) -> "IO": # pylint: disable=arguments-differ - return self.fs.open(path, mode=mode, encoding=encoding, **kwargs) + if "b" in mode: + kwargs.pop("encoding", None) + return self.fs.open(path, mode=mode, **kwargs) def read_block( self,