From 91bd0faa87560edb5df97371a1af8e1025008d32 Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Wed, 26 Jun 2019 16:25:56 -0500 Subject: [PATCH] dvc: feedback to #2112 round 1 --- dvc/stage.py | 4 ++-- tests/func/test_add.py | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/dvc/stage.py b/dvc/stage.py index 285a12336..4b76b0e2b 100644 --- a/dvc/stage.py +++ b/dvc/stage.py @@ -206,7 +206,7 @@ class Stage(object): @property def is_callback(self): """ - An orphan stage is always considered as changed, + A callback stage is always considered as changed, so it runs on every `dvc repro` call. """ return not self.is_data_source and len(self.deps) == 0 @@ -229,7 +229,7 @@ class Stage(object): if self.is_callback: logger.warning( - "DVC-file '{fname}' is an 'orphan' stage " + "DVC-file '{fname}' is an 'callback' stage " "(has a command and no dependencies) and thus always " "considered as changed.".format(fname=self.relpath) ) diff --git a/tests/func/test_add.py b/tests/func/test_add.py index ce3a8fecd..2c1aa2927 100644 --- a/tests/func/test_add.py +++ b/tests/func/test_add.py @@ -424,7 +424,7 @@ class TestShouldThrowProperExceptionOnCorruptedStageFile(TestDvc): foo_stage = relpath(self.FOO + Stage.STAGE_FILE_SUFFIX) - # corrupt DVC-file + # corrupt stage file with open(foo_stage, "a+") as file: file.write("this will break yaml file structure") @@ -475,7 +475,8 @@ class TestShouldCleanUpAfterFailedAdd(TestDvcGit): self.assertEqual(0, ret) foo_stage_file = self.FOO + Stage.STAGE_FILE_SUFFIX - # corrupt DVC-file + + # corrupt stage file with open(foo_stage_file, "a+") as file: file.write("this will break yaml file structure")