From 89bf7fce13feb1ec6e9aa09304e6b6a247b8feca Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Fri, 6 Nov 2020 04:10:54 +0200 Subject: [PATCH] dvc: limit aws-sam-translator version for moto (#4853) moto has aws-sam-translator as an indirect dependency that since 1.29.0 started to have a public package that causes conflicts in flufl.lock when it tries to use atpublic package. ``` tests/func/test_add.py:21: in from dvc.main import main dvc/main.py:7: in from dvc import analytics dvc/analytics.py:16: in from dvc.lock import Lock, LockError dvc/lock.py:8: in import flufl.lock /opt/hostedtoolcache/Python/3.6.12/x64/lib/python3.6/site-packages/flufl/lock/__init__.py:3: in from flufl.lock._lockfile import ( /opt/hostedtoolcache/Python/3.6.12/x64/lib/python3.6/site-packages/flufl/lock/_lockfile.py:42: in from public import public E ImportError: cannot import name 'public' ``` Oddly enough, this seems to also been causing pylint issues. public is a terrible name for a package SMH --- setup.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/setup.py b/setup.py index c57ecb93f..d610b0ae7 100644 --- a/setup.py +++ b/setup.py @@ -132,6 +132,9 @@ tests_requirements = [ "jaraco.windows==3.9.2", "mock-ssh-server>=0.8.2", "moto==1.3.14.dev464", + # moto's indirect dependency that is causing problems with flufl.lock's + # dependency (atpublic). See https://github.com/iterative/dvc/pull/4853 + "aws-sam-translator<1.29.0", "rangehttpserver==1.2.0", "beautifulsoup4==4.4.0", "flake8-bugbear",