From 896bbf1fc6eab1a3155e52063411f167dfbdb023 Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Fri, 10 Dec 2021 17:23:17 +0200 Subject: [PATCH] fs: get rid of unused DETAIL_FIELDS --- dvc/fs/azure.py | 1 - dvc/fs/base.py | 3 +-- dvc/fs/gs.py | 1 - dvc/fs/oss.py | 1 - dvc/fs/s3.py | 1 - dvc/fs/webdav.py | 1 - 6 files changed, 1 insertion(+), 7 deletions(-) diff --git a/dvc/fs/azure.py b/dvc/fs/azure.py index e3ff60e03..41ee4554b 100644 --- a/dvc/fs/azure.py +++ b/dvc/fs/azure.py @@ -41,7 +41,6 @@ def _az_config(): class AzureFileSystem(CallbackMixin, ObjectFSWrapper): scheme = Schemes.AZURE PARAM_CHECKSUM = "etag" - DETAIL_FIELDS = frozenset(("etag", "size")) REQUIRES = { "adlfs": "adlfs", "knack": "knack", diff --git a/dvc/fs/base.py b/dvc/fs/base.py index b9aaeeff2..af73de5ce 100644 --- a/dvc/fs/base.py +++ b/dvc/fs/base.py @@ -4,7 +4,7 @@ import os from concurrent.futures import ThreadPoolExecutor, as_completed from functools import partialmethod from multiprocessing import cpu_count -from typing import ClassVar, Dict, FrozenSet, Optional +from typing import ClassVar, Dict, Optional from funcy import cached_property from tqdm.utils import CallbackIOWrapper @@ -54,7 +54,6 @@ class FileSystem: CHUNK_SIZE = 64 * 1024 * 1024 # 64 MiB PARAM_CHECKSUM: ClassVar[Optional[str]] = None - DETAIL_FIELDS: FrozenSet[str] = frozenset() def __init__(self, **kwargs): self._check_requires(**kwargs) diff --git a/dvc/fs/gs.py b/dvc/fs/gs.py index a1954c602..41ef7bfb0 100644 --- a/dvc/fs/gs.py +++ b/dvc/fs/gs.py @@ -12,7 +12,6 @@ class GSFileSystem(CallbackMixin, ObjectFSWrapper): scheme = Schemes.GS REQUIRES = {"gcsfs": "gcsfs"} PARAM_CHECKSUM = "etag" - DETAIL_FIELDS = frozenset(("etag", "size")) def _prepare_credentials(self, **config): login_info = {"consistency": None} diff --git a/dvc/fs/oss.py b/dvc/fs/oss.py index cecf8f858..22e23d4c5 100644 --- a/dvc/fs/oss.py +++ b/dvc/fs/oss.py @@ -18,7 +18,6 @@ class OSSFileSystem(ObjectFSWrapper): PARAM_CHECKSUM = "etag" COPY_POLL_SECONDS = 5 LIST_OBJECT_PAGE_SIZE = 100 - DETAIL_FIELDS = frozenset(("etag", "size")) def _prepare_credentials(self, **config): login_info = {} diff --git a/dvc/fs/s3.py b/dvc/fs/s3.py index f233c5096..97e43a1c1 100644 --- a/dvc/fs/s3.py +++ b/dvc/fs/s3.py @@ -18,7 +18,6 @@ class BaseS3FileSystem(ObjectFSWrapper): scheme = Schemes.S3 REQUIRES = {"s3fs": "s3fs", "boto3": "boto3"} PARAM_CHECKSUM = "etag" - DETAIL_FIELDS = frozenset(("etag", "size")) _GRANTS = { "grant_full_control": "GrantFullControl", diff --git a/dvc/fs/webdav.py b/dvc/fs/webdav.py index 477760962..7540a4c5d 100644 --- a/dvc/fs/webdav.py +++ b/dvc/fs/webdav.py @@ -17,7 +17,6 @@ class WebDAVFileSystem(FSSpecWrapper): # pylint:disable=abstract-method TRAVERSE_PREFIX_LEN = 2 REQUIRES = {"webdav4": "webdav4"} PARAM_CHECKSUM = "etag" - DETAIL_FIELDS = frozenset(("etag", "size")) def __init__(self, **config): super().__init__(**config)