From 81d04f887a74a62755415e19d793740558a173ef Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Tue, 19 May 2020 03:30:52 +0300 Subject: [PATCH] stage: fix commit (#3816) --- dvc/stage/__init__.py | 6 +----- tests/func/test_commit.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/dvc/stage/__init__.py b/dvc/stage/__init__.py index 3729b86d5..79800ea6c 100644 --- a/dvc/stage/__init__.py +++ b/dvc/stage/__init__.py @@ -377,11 +377,7 @@ class Stage(params.StageParams): @staticmethod def _changed_entries(entries): - return [ - str(entry) - for entry in entries - if entry.checksum and entry.changed_checksum() - ] + return [str(entry) for entry in entries if entry.changed_checksum()] def _changed_stage_entry(self): return f"'md5' of {self} changed." diff --git a/tests/func/test_commit.py b/tests/func/test_commit.py index 75f7dbe8a..944ade59a 100644 --- a/tests/func/test_commit.py +++ b/tests/func/test_commit.py @@ -70,3 +70,13 @@ def test_commit_changed_md5(tmp_dir, dvc): dvc.commit(stage.path) dvc.commit(stage.path, force=True) + + +def test_commit_no_exec(tmp_dir, dvc): + tmp_dir.gen({"dep": "dep", "out": "out"}) + stage = dvc.run( + name="my", cmd="mycmd", deps=["dep"], outs=["out"], no_exec=True + ) + assert dvc.status(stage.path) + dvc.commit(stage.path, force=True) + assert dvc.status(stage.path) == {}