From 8154c89c3f5e306bf6a9368ae26faa2ac4d09eed Mon Sep 17 00:00:00 2001 From: Ruslan Kuprieiev Date: Fri, 10 Jan 2020 20:53:59 +0200 Subject: [PATCH] tests: remove redundant native ssh tests We already have mocked ones, which are more reliable as they use their own paramiko server instead of relying on the sshd running on the test machine. Native tests are also quite flaky and fail sometimes due to network issues. --- tests/func/test_data_cloud.py | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/tests/func/test_data_cloud.py b/tests/func/test_data_cloud.py index e69ffa958..427005063 100644 --- a/tests/func/test_data_cloud.py +++ b/tests/func/test_data_cloud.py @@ -33,7 +33,6 @@ from tests.utils import spy from tests.remotes import ( _should_test_gcp, _should_test_hdfs, - _should_test_ssh, Azure, GDrive, S3, @@ -47,7 +46,6 @@ from tests.remotes import ( get_gcp_url, get_hdfs_url, get_local_url, - get_ssh_url, get_ssh_url_mocked, ) @@ -296,17 +294,6 @@ class TestRemoteLOCAL(TestDataCloudBase): self.assertTrue(os.path.isdir(self.dname)) -class TestRemoteSSH(TestDataCloudBase): - def _should_test(self): - return _should_test_ssh() - - def _get_url(self): - return get_ssh_url() - - def _get_cloud_class(self): - return RemoteSSH - - @pytest.mark.usefixtures("ssh_server") class TestRemoteSSHMocked(TestDataCloudBase): @pytest.fixture(autouse=True) @@ -442,18 +429,6 @@ class TestRemoteLOCALCLI(TestDataCloudCLIBase): self._test_cloud(TEST_REMOTE) -class TestRemoteSSHCLI(TestDataCloudCLIBase): - def _should_test(self): - return _should_test_ssh() - - def _test(self): - url = get_ssh_url() - - self.main(["remote", "add", TEST_REMOTE, url]) - - self._test_cloud(TEST_REMOTE) - - class TestRemoteHDFSCLI(TestDataCloudCLIBase): def _should_test(self): return _should_test_hdfs()