From 7b1dbd610976901228f703fec12ef9ed016c0108 Mon Sep 17 00:00:00 2001 From: Ivan Shcheklein Date: Sat, 4 Apr 2020 12:18:14 -0700 Subject: [PATCH] CLI: redirect warnings to logger (#3591) * redirect warnings module messages to logger to silent them in gdrive * minor cleanup: remove unused var assignment * dvc: don't ignore warnings manually We use logger.captureWarnings() instead for CLI and for API this is harmful. Co-authored-by: Ruslan Kuprieiev --- dvc/__init__.py | 9 --------- dvc/logger.py | 1 + dvc/main.py | 1 - 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/dvc/__init__.py b/dvc/__init__.py index 8d8b10b51..583a8463d 100644 --- a/dvc/__init__.py +++ b/dvc/__init__.py @@ -3,17 +3,8 @@ DVC ---- Make your data science projects reproducible and shareable. """ -import warnings - import dvc.logger from dvc.version import __version__ # noqa: F401 dvc.logger.setup() - -# Ignore numpy's runtime warnings: https://github.com/numpy/numpy/pull/432. -# We don't directly import numpy, but our dependency networkx does, causing -# these warnings in some environments. Luckily these warnings are benign and -# we can simply ignore them so that they don't show up when you are using dvc. -warnings.filterwarnings("ignore", message="numpy.dtype size changed") -warnings.filterwarnings("ignore", message="numpy.ufunc size changed") diff --git a/dvc/logger.py b/dvc/logger.py index 23f65c061..dafe5f7ee 100644 --- a/dvc/logger.py +++ b/dvc/logger.py @@ -143,6 +143,7 @@ def _stack_trace(exc_info): def disable_other_loggers(): + logging.captureWarnings(True) root = logging.root for (logger_name, logger) in root.manager.loggerDict.items(): if logger_name != "dvc" and not logger_name.startswith("dvc."): diff --git a/dvc/main.py b/dvc/main.py index 9caaedd29..91b2a3358 100644 --- a/dvc/main.py +++ b/dvc/main.py @@ -33,7 +33,6 @@ def main(argv=None): int: command's return code. """ args = None - cmd = None disable_other_loggers() outerLogLevel = logger.level