From 73980a1a4bb55ebfb6639beb11d02ee07d1d3f00 Mon Sep 17 00:00:00 2001 From: Dmitry Petrov Date: Fri, 28 Apr 2017 14:58:06 -0700 Subject: [PATCH] Sync: warning if file cannot be synced --- dvc/command/data_sync.py | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py index 66ec4b7ac..8d093a954 100644 --- a/dvc/command/data_sync.py +++ b/dvc/command/data_sync.py @@ -66,21 +66,24 @@ class CmdDataSync(CmdBase): elif os.path.isdir(target): self.sync_dir(target) else: - # if data_item.data.dvc != empty_data_item.data.dvc: raise DataSyncError('File "{}" does not exit'.format(target)) finally: if self.is_locker: lock.release() def sync_dir(self, dir): - for f in os.listdir(dir): - fname = os.path.join(dir, f) - if os.path.isdir(fname): - self.sync_dir(fname) - elif System.islink(fname): - self.sync_symlink(self.settings.path_factory.data_item(fname)) - else: - raise DataSyncError('Unsupported file type "{}"'.format(fname)) + for file in os.listdir(dir): + try: + fname = os.path.join(dir, file) + if os.path.isdir(fname): + self.sync_dir(fname) + elif System.islink(fname): + self.sync_symlink(self.settings.path_factory.data_item(fname)) + else: + raise DataSyncError('Unsupported file type "{}"'.format(fname)) + except DataSyncError as ex: + Logger.warn(ex) + pass def sync_symlink(self, data_item): if os.path.isfile(data_item.resolved_cache.dvc): @@ -181,7 +184,6 @@ class CmdDataSync(CmdBase): blob.upload_from_filename(data_item.resolved_cache.relative) Logger.info('uploading %s completed' % data_item.resolved_cache.relative) - def sync_from_cloud(self, item): cloud = self.settings.config.cloud assert cloud in ['amazon', 'google'], 'unknown cloud %s' % cloud