From 69c1aa5bbf3b08ca143afe73894499a7a6121482 Mon Sep 17 00:00:00 2001 From: Jorge Orpinel Date: Thu, 23 Jan 2020 00:50:24 -0600 Subject: [PATCH] dvc: revert capitalization of logger.exception strings per https://github.com/iterative/dvc/pull/3220#pullrequestreview-347083819 --- dvc/command/get.py | 2 +- dvc/command/init.py | 2 +- dvc/command/install.py | 2 +- tests/func/test_get.py | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dvc/command/get.py b/dvc/command/get.py index 76e50ee82..e27c178b5 100644 --- a/dvc/command/get.py +++ b/dvc/command/get.py @@ -19,7 +19,7 @@ class CmdGet(CmdBaseNoRepo): ) logger.info(url) except DvcException: - logger.exception("Failed to show URL") + logger.exception("failed to show URL") return 1 return 0 diff --git a/dvc/command/init.py b/dvc/command/init.py index 35dfc5154..fe0951d48 100644 --- a/dvc/command/init.py +++ b/dvc/command/init.py @@ -19,7 +19,7 @@ class CmdInit(CmdBaseNoRepo): ) self.config = self.repo.config except InitError: - logger.exception("Failed to initiate DVC") + logger.exception("failed to initiate DVC") return 1 return 0 diff --git a/dvc/command/install.py b/dvc/command/install.py index 6df33e45a..1dea3fcb0 100644 --- a/dvc/command/install.py +++ b/dvc/command/install.py @@ -13,7 +13,7 @@ class CmdInstall(CmdBase): try: self.repo.install() except Exception: - logger.exception("Failed to install DVC Git hooks") + logger.exception("failed to install DVC Git hooks") return 1 return 0 diff --git a/tests/func/test_get.py b/tests/func/test_get.py index efc3c1351..45f839355 100644 --- a/tests/func/test_get.py +++ b/tests/func/test_get.py @@ -190,7 +190,7 @@ def test_get_url_not_existing(tmp_dir, erepo_dir, caplog): main(["get", fspath(erepo_dir), "not-existing-file", "--show-url"]) == 1 ) - assert "Failed to show URL" in caplog.text + assert "failed to show URL" in caplog.text def test_get_url_git_only_repo(tmp_dir, scm, caplog): @@ -198,4 +198,4 @@ def test_get_url_git_only_repo(tmp_dir, scm, caplog): with caplog.at_level(logging.ERROR): assert main(["get", fspath(tmp_dir), "foo", "--show-url"]) == 1 - assert "Failed to show URL" in caplog.text + assert "failed to show URL" in caplog.text